From: Andrew Morton <akpm@linux-foundation.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Tony Luck <tony.luck@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Ingo Molnar <mingo@elte.hu>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2 v2] HWPOISON: fix action_result() to print out dirty/clean
Date: Mon, 5 Nov 2012 13:56:28 -0800 [thread overview]
Message-ID: <20121105135628.db79602c.akpm@linux-foundation.org> (raw)
In-Reply-To: <1351873993-9373-2-git-send-email-n-horiguchi@ah.jp.nec.com>
On Fri, 2 Nov 2012 12:33:12 -0400
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> action_result() fails to print out "dirty" even if an error occurred on a
> dirty pagecache, because when we check PageDirty in action_result() it was
> cleared after page isolation even if it's dirty before error handling. This
> can break some applications that monitor this message, so should be fixed.
>
> There are several callers of action_result() except page_action(), but
> either of them are not for LRU pages but for free pages or kernel pages,
> so we don't have to consider dirty or not for them.
>
> Note that PG_dirty can be set outside page locks as described in commit
> 554940dc8c1e, so this patch does not completely closes the race window,
> but just narrows it.
I can find no commit 554940dc8c1e. What commit are you referring to here?
This is one of the reasons why we ask people to refer to commits by
both hash and by name, using the form
078de5f706ece3 ("userns: Store uid and gid values in struct cred with
kuid_t and kgid_t types")
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-05 21:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 16:33 [PATCH 0/2] HWPOISON: improve logging Naoya Horiguchi
2012-11-02 16:33 ` [PATCH 1/2 v2] HWPOISON: fix action_result() to print out dirty/clean Naoya Horiguchi
2012-11-05 21:56 ` Andrew Morton [this message]
2012-11-05 22:40 ` [PATCH v3] HWPOISON: fix action_result() to print out dirty/clean (Re: [PATCH 1/2 v2] HWPOISON: fix action_result() to print out) dirty/clean Naoya Horiguchi
2012-11-02 16:33 ` [PATCH 2/2 v2] mm: print out information of file affected by memory error Naoya Horiguchi
2012-11-05 22:01 ` Andrew Morton
2012-11-06 5:07 ` Naoya Horiguchi
2012-11-06 20:12 ` Andrew Morton
2012-11-06 22:45 ` Naoya Horiguchi
2012-11-06 22:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105135628.db79602c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).