From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx126.postini.com [74.125.245.126]) by kanga.kvack.org (Postfix) with SMTP id D79C96B0044 for ; Tue, 6 Nov 2012 18:24:28 -0500 (EST) Date: Tue, 6 Nov 2012 15:24:27 -0800 From: Andrew Morton Subject: Re: [PATCH v4 3/6] block/genhd.c: apply pm_runtime_set_memalloc_noio on block devices Message-Id: <20121106152427.dfde4c52.akpm@linux-foundation.org> In-Reply-To: <1351931714-11689-4-git-send-email-ming.lei@canonical.com> References: <1351931714-11689-1-git-send-email-ming.lei@canonical.com> <1351931714-11689-4-git-send-email-ming.lei@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Ming Lei Cc: linux-kernel@vger.kernel.org, Alan Stern , Oliver Neukum , Minchan Kim , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jens Axboe , "David S. Miller" , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-mm@kvack.org On Sat, 3 Nov 2012 16:35:11 +0800 Ming Lei wrote: > This patch applyes the introduced pm_runtime_set_memalloc_noio on > block device so that PM core will teach mm to not allocate memory with > GFP_IOFS when calling the runtime_resume and runtime_suspend callback > for block devices and its ancestors. > > ... > > @@ -532,6 +533,13 @@ static void register_disk(struct gendisk *disk) > return; > } > } > + > + /* avoid probable deadlock caused by allocating memory with Again, please fix the comment style. Take a look at the rest of this file! > + * GFP_KERNEL in runtime_resume callback of its all ancestor > + * deivces typo > + */ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org