From: Shaohua Li <shli@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
minchan@kernel.org, riel@redhat.com
Subject: Re: [patch 1/2 v2]swap: add a simple buddy allocator
Date: Tue, 20 Nov 2012 09:41:25 +0800 [thread overview]
Message-ID: <20121120014125.GA2222@kernel.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1211190151320.20469@eggly.anvils>
On Mon, Nov 19, 2012 at 02:06:48AM -0800, Hugh Dickins wrote:
> On Mon, 19 Nov 2012, Shaohua Li wrote:
> >
> > Changes from V1 to V2:
> > 1. free cluster is added to a list, which makes searching cluster more efficient
> > 2. only enable the buddy allocator for SSD.
>
> Oh. My fault, not yours at all, but I wish I'd known this was coming.
> I spent today testing and fixing (a couple of hangs in discard 2/2) V1,
> was about to send you a patch, but looks like none of it relevant to V2.
Appologize for this. I was in travel last whole week, a little lagged to fully
test the V2 patch till yesterday. Had no confidence to bother again before I
know it really works.
> It's nice work you've done, I thoroughly approve of V1 (very minor mods),
> but it'll take me a few more days to get around to looking at V2, sorry.
>
> Though, it may be my ignorance, I entirely fail to see what this has to
> do with a buddy allocator: you've speeded up scan_swap_map()'s search
> for a cluster by adding an additional cluster map, then extended that
> neatly for a much better discard implementation. Good work yes, but
> a buddy allocator??
That is just the name I called. I thought it's a variant of buddy allocator,
don't take it serious.
Thanks,
Shaohua
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-11-20 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 7:59 [patch 1/2 v2]swap: add a simple buddy allocator Shaohua Li
2012-11-19 10:06 ` Hugh Dickins
2012-11-20 1:41 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120014125.GA2222@kernel.org \
--to=shli@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).