* [memcg:since-3.6 456/496] drivers/virtio/virtio_balloon.c:145:10: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int'
@ 2012-11-21 15:37 kbuild test robot
2012-11-21 15:47 ` Michal Hocko
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2012-11-21 15:37 UTC (permalink / raw)
To: Rafael Aquini; +Cc: linux-mm, Andrew Morton, Michal Hocko
tree: git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.6
head: 223cdc1faeea55aa70fef23d54720ad3fdaf4c93
commit: 12cf48af8968fa1d0cc4c06065d7c37c3560c171 [456/496] virtio_balloon: introduce migration primitives to balloon pages
config: make ARCH=x86_64 allmodconfig
All warnings:
drivers/virtio/virtio_balloon.c: In function 'fill_balloon':
drivers/virtio/virtio_balloon.c:145:10: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' [-Wformat]
vim +145 drivers/virtio/virtio_balloon.c
6b35e407 Rusty Russell 2008-02-04 129 static void fill_balloon(struct virtio_balloon *vb, size_t num)
6b35e407 Rusty Russell 2008-02-04 130 {
12cf48af Rafael Aquini 2012-11-21 131 struct balloon_dev_info *vb_dev_info = vb->vb_dev_info;
12cf48af Rafael Aquini 2012-11-21 132
6b35e407 Rusty Russell 2008-02-04 133 /* We can only do one array worth at a time. */
6b35e407 Rusty Russell 2008-02-04 134 num = min(num, ARRAY_SIZE(vb->pfns));
6b35e407 Rusty Russell 2008-02-04 135
12cf48af Rafael Aquini 2012-11-21 136 mutex_lock(&vb->balloon_lock);
3ccc9372 Michael S. Tsirkin 2012-04-12 137 for (vb->num_pfns = 0; vb->num_pfns < num;
3ccc9372 Michael S. Tsirkin 2012-04-12 138 vb->num_pfns += VIRTIO_BALLOON_PAGES_PER_PAGE) {
12cf48af Rafael Aquini 2012-11-21 139 struct page *page = balloon_page_enqueue(vb_dev_info);
12cf48af Rafael Aquini 2012-11-21 140
6b35e407 Rusty Russell 2008-02-04 141 if (!page) {
6b35e407 Rusty Russell 2008-02-04 142 if (printk_ratelimit())
6b35e407 Rusty Russell 2008-02-04 143 dev_printk(KERN_INFO, &vb->vdev->dev,
4f2ac849 Michal Hocko 2012-11-21 144 "Out of puff! Can't get %zu pages\n",
12cf48af Rafael Aquini 2012-11-21 @145 VIRTIO_BALLOON_PAGES_PER_PAGE);
6b35e407 Rusty Russell 2008-02-04 146 /* Sleep for at least 1/5 of a second before retry. */
6b35e407 Rusty Russell 2008-02-04 147 msleep(200);
6b35e407 Rusty Russell 2008-02-04 148 break;
6b35e407 Rusty Russell 2008-02-04 149 }
3ccc9372 Michael S. Tsirkin 2012-04-12 150 set_page_pfns(vb->pfns + vb->num_pfns, page);
3ccc9372 Michael S. Tsirkin 2012-04-12 151 vb->num_pages += VIRTIO_BALLOON_PAGES_PER_PAGE;
6b35e407 Rusty Russell 2008-02-04 152 totalram_pages--;
6b35e407 Rusty Russell 2008-02-04 153 }
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [memcg:since-3.6 456/496] drivers/virtio/virtio_balloon.c:145:10: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int'
2012-11-21 15:37 [memcg:since-3.6 456/496] drivers/virtio/virtio_balloon.c:145:10: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' kbuild test robot
@ 2012-11-21 15:47 ` Michal Hocko
2012-11-21 19:55 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Michal Hocko @ 2012-11-21 15:47 UTC (permalink / raw)
To: kbuild test robot; +Cc: Rafael Aquini, linux-mm, Andrew Morton
Bahh, my fault.
I screwed while reverting previous version of the virtio patchset.
Pushed to my tree. Thanks for reporting...
On Wed 21-11-12 23:37:21, Wu Fengguang wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.6
> head: 223cdc1faeea55aa70fef23d54720ad3fdaf4c93
> commit: 12cf48af8968fa1d0cc4c06065d7c37c3560c171 [456/496] virtio_balloon: introduce migration primitives to balloon pages
> config: make ARCH=x86_64 allmodconfig
---
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [memcg:since-3.6 456/496] drivers/virtio/virtio_balloon.c:145:10: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int'
2012-11-21 15:47 ` Michal Hocko
@ 2012-11-21 19:55 ` Andrew Morton
2012-11-22 9:08 ` Michal Hocko
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2012-11-21 19:55 UTC (permalink / raw)
To: Michal Hocko; +Cc: kbuild test robot, Rafael Aquini, linux-mm
On Wed, 21 Nov 2012 16:47:34 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> Bahh, my fault.
> I screwed while reverting previous version of the virtio patchset.
> Pushed to my tree. Thanks for reporting...
>
> On Wed 21-11-12 23:37:21, Wu Fengguang wrote:
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.6
> > head: 223cdc1faeea55aa70fef23d54720ad3fdaf4c93
> > commit: 12cf48af8968fa1d0cc4c06065d7c37c3560c171 [456/496] virtio_balloon: introduce migration primitives to balloon pages
> > config: make ARCH=x86_64 allmodconfig
> ---
> >From 35f423ffe01b62cbe5bf88b0acbff5b3b4a09777 Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse.cz>
> Date: Wed, 21 Nov 2012 16:42:02 +0100
> Subject: [PATCH] virtio_balloon-introduce-migration-primitives-to-balloon-pages-fix-fix-fix
> mismerge fix
>
> %u got back to %zu while while reverting
> %(4f2ac8495ba0477d8c3208de96dae7d1db6c2d49) obsolete version of
> virtio_balloon: introduce migration primitives to balloon pages
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
> drivers/virtio/virtio_balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index d0cfb7e..8cde4c9 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -141,7 +141,7 @@ static void fill_balloon(struct virtio_balloon *vb, size_t num)
> if (!page) {
> if (printk_ratelimit())
> dev_printk(KERN_INFO, &vb->vdev->dev,
> - "Out of puff! Can't get %zu pages\n",
> + "Out of puff! Can't get %u pages\n",
> VIRTIO_BALLOON_PAGES_PER_PAGE);
> /* Sleep for at least 1/5 of a second before retry. */
> msleep(200);
Yeah, that's quite old code - printk_ratelimit is naughty and has been
replaced by dev_info_ratelimited().
Are you using mmotm or http://ozlabs.org/~akpm/mmots/? It might be
better to grab mmots at least while linux-next is on pause.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [memcg:since-3.6 456/496] drivers/virtio/virtio_balloon.c:145:10: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int'
2012-11-21 19:55 ` Andrew Morton
@ 2012-11-22 9:08 ` Michal Hocko
0 siblings, 0 replies; 4+ messages in thread
From: Michal Hocko @ 2012-11-22 9:08 UTC (permalink / raw)
To: Andrew Morton; +Cc: kbuild test robot, Rafael Aquini, linux-mm
On Wed 21-11-12 11:55:16, Andrew Morton wrote:
> On Wed, 21 Nov 2012 16:47:34 +0100
> Michal Hocko <mhocko@suse.cz> wrote:
>
> > Bahh, my fault.
> > I screwed while reverting previous version of the virtio patchset.
> > Pushed to my tree. Thanks for reporting...
> >
> > On Wed 21-11-12 23:37:21, Wu Fengguang wrote:
> > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.6
> > > head: 223cdc1faeea55aa70fef23d54720ad3fdaf4c93
> > > commit: 12cf48af8968fa1d0cc4c06065d7c37c3560c171 [456/496] virtio_balloon: introduce migration primitives to balloon pages
> > > config: make ARCH=x86_64 allmodconfig
> > ---
> > >From 35f423ffe01b62cbe5bf88b0acbff5b3b4a09777 Mon Sep 17 00:00:00 2001
> > From: Michal Hocko <mhocko@suse.cz>
> > Date: Wed, 21 Nov 2012 16:42:02 +0100
> > Subject: [PATCH] virtio_balloon-introduce-migration-primitives-to-balloon-pages-fix-fix-fix
> > mismerge fix
> >
> > %u got back to %zu while while reverting
> > %(4f2ac8495ba0477d8c3208de96dae7d1db6c2d49) obsolete version of
> > virtio_balloon: introduce migration primitives to balloon pages
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.cz>
> > ---
> > drivers/virtio/virtio_balloon.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> > index d0cfb7e..8cde4c9 100644
> > --- a/drivers/virtio/virtio_balloon.c
> > +++ b/drivers/virtio/virtio_balloon.c
> > @@ -141,7 +141,7 @@ static void fill_balloon(struct virtio_balloon *vb, size_t num)
> > if (!page) {
> > if (printk_ratelimit())
> > dev_printk(KERN_INFO, &vb->vdev->dev,
> > - "Out of puff! Can't get %zu pages\n",
> > + "Out of puff! Can't get %u pages\n",
> > VIRTIO_BALLOON_PAGES_PER_PAGE);
> > /* Sleep for at least 1/5 of a second before retry. */
> > msleep(200);
>
> Yeah, that's quite old code - printk_ratelimit is naughty and has been
> replaced by dev_info_ratelimited().
Hmm, that one came in from linux-next (looks like Rusty's tree) and
not your tree so I haven't applied it. I can cherry pick (the last
linux-next knows it as 41395dfb: virtio: Convert dev_printk(KERN_<LEVEL>
to dev_<level>) of course.
>
> Are you using mmotm or http://ozlabs.org/~akpm/mmots/?
both. mmots every day (if there is a new one) and mmotm when it is
announced.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-22 9:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 15:37 [memcg:since-3.6 456/496] drivers/virtio/virtio_balloon.c:145:10: warning: format '%zu' expects argument of type 'size_t', but argument 4 has type 'unsigned int' kbuild test robot
2012-11-21 15:47 ` Michal Hocko
2012-11-21 19:55 ` Andrew Morton
2012-11-22 9:08 ` Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).