From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx114.postini.com [74.125.245.114]) by kanga.kvack.org (Postfix) with SMTP id DE6766B0044 for ; Wed, 21 Nov 2012 12:10:53 -0500 (EST) Received: by mail-ee0-f41.google.com with SMTP id d41so5169080eek.14 for ; Wed, 21 Nov 2012 09:10:52 -0800 (PST) Date: Wed, 21 Nov 2012 18:10:47 +0100 From: Ingo Molnar Subject: Re: [PATCH 00/27] Latest numa/core release, v16 Message-ID: <20121121171047.GA28875@gmail.com> References: <1353291284-2998-1-git-send-email-mingo@kernel.org> <20121119162909.GL8218@suse.de> <20121120060014.GA14065@gmail.com> <20121120074445.GA14539@gmail.com> <20121120090637.GA14873@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: David Rientjes , Mel Gorman , Linux Kernel Mailing List , linux-mm , Peter Zijlstra , Paul Turner , Lee Schermerhorn , Christoph Lameter , Rik van Riel , Andrew Morton , Andrea Arcangeli , Thomas Gleixner , Johannes Weiner , Hugh Dickins * Linus Torvalds wrote: > On Mon, Nov 19, 2012 at 11:06 PM, Ingo Molnar wrote: > > > > Oh, finally a clue: you seem to have vsyscall emulation > > overhead! > > Ingo, stop it already! > > This is *exactly* the kind of "blame everybody else than > yourself" behavior that I was talking about earlier. > > There have been an absolute *shitload* of patches to try to > make up for the schednuma regressions THAT HAVE ABSOLUTELY > NOTHING TO DO WITH SCHEDNUMA, and are all about trying to work > around the fact that it regresses. The whole TLB optimization, > and now this kind of crap. > > Ingo, look your code in the mirror some day, and ask yourself: > why do you think this fixes a "regression"? Because scalability slowdowns are often non-linear. So with CONFIG_NUMA_BALANCING=y we are taking a higher page fault rate, in exchange for a speedup. But if some other factor further increases the page fault rate (such as vsyscall emulation) then the speedup can be non-linearly slower than the cost of the technique - washing it out or even turning it into an outright regression. So, for example: - 10K page faults/sec from CONFIG_SCHED_BALANCING: 0.5% cost - 10K page faults/sec from vsyscall emu: 0.5% cost If the two are mixed together the slowdown is non-linear: - 10K+10K page faults/sec overhead is not a linear 1%, but might be 3% So because I did not have an old-glibc system like David's, I did not know the actual page fault rate. If it is high enough then nonlinear effects might cause such effects. This is an entirely valid line of inquiry IMO. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org