From: Fengguang Wu <fengguang.wu@intel.com>
To: Rafael Aquini <aquini@redhat.com>
Cc: kbuild@01.org, Julia Lawall <julia.lawall@lip6.fr>,
Michal Hocko <mhocko@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: [memcg:since-3.6 341/499] drivers/virtio/virtio_balloon.c:157:2-8: preceding lock on line 136
Date: Fri, 30 Nov 2012 08:28:48 +0800 [thread overview]
Message-ID: <20121130002848.GA28177@localhost> (raw)
In-Reply-To: <50b79f52.Rxsdi7iwHf+1mkK5%fengguang.wu@intel.com>
Hi Rafael,
[Julia and me think that this coccinelle warning is worth reporting.]
tree: git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.6
head: 422a0f651b5cefa1b6b3ede2e1c9e540a24a6e01
commit: 5f1da4063294480b3fabcee554f976565dec54b5 [341/499] virtio_balloon: introduce migration primitives to balloon pages
+ drivers/virtio/virtio_balloon.c:157:2-8: preceding lock on line 136
vim +157 drivers/virtio/virtio_balloon.c
6b35e407 Rusty Russell 2008-02-04 130 {
5f1da406 Rafael Aquini 2012-11-09 131 struct balloon_dev_info *vb_dev_info = vb->vb_dev_info;
5f1da406 Rafael Aquini 2012-11-09 132
6b35e407 Rusty Russell 2008-02-04 133 /* We can only do one array worth at a time. */
6b35e407 Rusty Russell 2008-02-04 134 num = min(num, ARRAY_SIZE(vb->pfns));
6b35e407 Rusty Russell 2008-02-04 135
5f1da406 Rafael Aquini 2012-11-09 @136 mutex_lock(&vb->balloon_lock);
3ccc9372 Michael S. Tsirkin 2012-04-12 137 for (vb->num_pfns = 0; vb->num_pfns < num;
3ccc9372 Michael S. Tsirkin 2012-04-12 138 vb->num_pfns += VIRTIO_BALLOON_PAGES_PER_PAGE) {
5f1da406 Rafael Aquini 2012-11-09 139 struct page *page = balloon_page_enqueue(vb_dev_info);
5f1da406 Rafael Aquini 2012-11-09 140
6b35e407 Rusty Russell 2008-02-04 141 if (!page) {
6b35e407 Rusty Russell 2008-02-04 142 if (printk_ratelimit())
6b35e407 Rusty Russell 2008-02-04 143 dev_printk(KERN_INFO, &vb->vdev->dev,
6b35e407 Rusty Russell 2008-02-04 144 "Out of puff! Can't get %zu pages\n",
5f1da406 Rafael Aquini 2012-11-09 145 VIRTIO_BALLOON_PAGES_PER_PAGE);
6b35e407 Rusty Russell 2008-02-04 146 /* Sleep for at least 1/5 of a second before retry. */
6b35e407 Rusty Russell 2008-02-04 147 msleep(200);
6b35e407 Rusty Russell 2008-02-04 148 break;
6b35e407 Rusty Russell 2008-02-04 149 }
3ccc9372 Michael S. Tsirkin 2012-04-12 150 set_page_pfns(vb->pfns + vb->num_pfns, page);
3ccc9372 Michael S. Tsirkin 2012-04-12 151 vb->num_pages += VIRTIO_BALLOON_PAGES_PER_PAGE;
6b35e407 Rusty Russell 2008-02-04 152 totalram_pages--;
6b35e407 Rusty Russell 2008-02-04 153 }
6b35e407 Rusty Russell 2008-02-04 154
6b35e407 Rusty Russell 2008-02-04 155 /* Didn't get any? Oh well. */
6b35e407 Rusty Russell 2008-02-04 156 if (vb->num_pfns == 0)
6b35e407 Rusty Russell 2008-02-04 @157 return;
6b35e407 Rusty Russell 2008-02-04 158
6b35e407 Rusty Russell 2008-02-04 159 tell_host(vb, vb->inflate_vq);
5f1da406 Rafael Aquini 2012-11-09 160 mutex_unlock(&vb->balloon_lock);
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2012-11-30 0:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50b79f52.Rxsdi7iwHf+1mkK5%fengguang.wu@intel.com>
2012-11-30 0:28 ` Fengguang Wu [this message]
2012-11-30 0:46 ` [memcg:since-3.6 341/499] drivers/virtio/virtio_balloon.c:157:2-8: preceding lock on line 136 Andrew Morton
2012-11-30 2:00 ` Fengguang Wu
2012-11-30 2:07 ` Andrew Morton
2012-11-30 18:14 ` Michal Hocko
2012-11-30 21:44 ` Fengguang Wu
2012-12-02 10:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130002848.GA28177@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=kbuild@01.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).