From: Tejun Heo <tj@kernel.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <jaxboe@fusionio.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Zach Brown <zab@redhat.com>, Peter Zijlstra <pzijlstr@redhat.com>,
Ingo <mingo@redhat.com>
Subject: Re: [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads
Date: Thu, 6 Dec 2012 10:13:10 -0800 [thread overview]
Message-ID: <20121206181310.GR19802@htj.dyndns.org> (raw)
In-Reply-To: <x494njzxdd9.fsf@segfault.boston.devel.redhat.com>
Hello,
On Thu, Dec 06, 2012 at 01:08:18PM -0500, Jeff Moyer wrote:
> > As for the original patch, I think it's a bit too much to expose to
> > userland. It's probably a good idea to bind the flusher to the local
> > node but do we really need to expose an interface to let userland
> > control the affinity directly? Do we actually have a use case at
> > hand?
>
> Yeah, folks pinning realtime processes to a particular cpu don't want
> the flusher threads interfering with their latency. I don't have any
> performance numbers on hand to convince you of the benefit, though.
What I don't get is, RT tasks win over bdi flushers every time and I'm
skeptical allowing bdi or not on a particular CPU would make a big
difference on non-RT kernels anyway. If the use case calls for
stricter isolation, there's isolcpus. While I can see why someone
might think that they need something like this, I'm not sure it's
actually something necessary.
And, even if it's actually something necessary, I think we'll probably
be better off with adding a mechanism to notify userland of new
kthreads and let userland adjust affinity using the usual mechanism
rather than adding dedicated knobs for each kthread users.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-12-06 18:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 18:53 [patch,v2] bdi: add a user-tunable cpu_list for the bdi flusher threads Jeff Moyer
2012-12-04 2:34 ` Dave Chinner
2012-12-04 14:42 ` Jeff Moyer
2012-12-04 20:35 ` Dave Chinner
2012-12-04 20:14 ` Jens Axboe
2012-12-04 20:23 ` Jeff Moyer
2012-12-04 20:27 ` Jens Axboe
2012-12-04 22:26 ` Jeff Moyer
2012-12-05 7:43 ` Jens Axboe
2012-12-06 18:01 ` Tejun Heo
2012-12-06 18:08 ` Jeff Moyer
2012-12-06 18:13 ` Tejun Heo [this message]
2012-12-06 18:19 ` Jens Axboe
2012-12-06 18:22 ` Tejun Heo
2012-12-06 18:33 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206181310.GR19802@htj.dyndns.org \
--to=tj@kernel.org \
--cc=jaxboe@fusionio.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pzijlstr@redhat.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).