From: Andrew Morton <akpm@linux-foundation.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: aneesh.kumar@linux.vnet.ibm.com,
Andi Kleen <andi.kleen@intel.com>,
Tony Luck <tony.luck@intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] HWPOISON, hugetlbfs: fix warning on freeing hwpoisoned hugepage
Date: Fri, 7 Dec 2012 14:34:14 -0800 [thread overview]
Message-ID: <20121207143414.b2d33095.akpm@linux-foundation.org> (raw)
In-Reply-To: <1354895397-21736-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On Fri, 7 Dec 2012 10:49:57 -0500
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> This patch fixes the warning from __list_del_entry() which is triggered
> when a process tries to do free_huge_page() for a hwpoisoned hugepage.
This changelog is very short. In fact it is too short, resulting in
others having to ask questions about the patch. When this happens,
please treat it as a sign that the changelog needs additional
information - so that other readers will not feel a need to ask the
same questions!
I added this paragraph:
: free_huge_page() can be called for hwpoisoned hugepage from
: unpoison_memory(). This function gets refcount once and clears
: PageHWPoison, and then puts refcount twice to return the hugepage back to
: free pool. The second put_page() finally reaches free_huge_page().
Also, is the description accurate? Is the __list_del_entry() warning
the only problem?
Or is it the case that this bug will cause memory corruption? If so
then the patch is pretty important and is probably needed in -stable as
well? I haven't checked how far back in time the bug exists.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-12-07 22:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 21:47 [PATCH 0/3] HWPOISON, hugetlbfs: small bug fixes Naoya Horiguchi
2012-12-05 21:47 ` [PATCH 1/3] HWPOISON, hugetlbfs: fix warning on freeing hwpoisoned hugepage Naoya Horiguchi
2012-12-05 22:13 ` Luck, Tony
2012-12-07 2:18 ` Naoya Horiguchi
2012-12-06 22:36 ` Andrew Morton
2012-12-07 2:03 ` Naoya Horiguchi
2012-12-07 2:20 ` Andrew Morton
2012-12-07 5:48 ` Naoya Horiguchi
2012-12-07 5:36 ` Aneesh Kumar K.V
2012-12-07 6:14 ` Naoya Horiguchi
2012-12-07 7:54 ` Aneesh Kumar K.V
2012-12-07 15:49 ` Naoya Horiguchi
2012-12-07 22:34 ` Andrew Morton [this message]
2012-12-08 21:04 ` Naoya Horiguchi
2012-12-05 21:47 ` [PATCH 2/3] HWPOISON, hugetlbfs: fix "bad pmd" warning in unmapping " Naoya Horiguchi
2012-12-05 21:47 ` [PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning Naoya Horiguchi
2012-12-05 22:04 ` Luck, Tony
2012-12-05 22:14 ` Naoya Horiguchi
2012-12-06 22:40 ` Andrew Morton
2012-12-07 1:22 ` Naoya Horiguchi
2012-12-07 2:10 ` Andrew Morton
2012-12-10 11:17 ` Simon Jeons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207143414.b2d33095.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).