From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx137.postini.com [74.125.245.137]) by kanga.kvack.org (Postfix) with SMTP id 79FF36B005A for ; Mon, 10 Dec 2012 21:45:49 -0500 (EST) Date: Tue, 11 Dec 2012 10:45:22 +0800 From: Fengguang Wu Subject: Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics Message-ID: <20121211024522.GA10505@localhost> References: <50C1AD6D.7010709@huawei.com> <20121207141102.4fda582d.akpm@linux-foundation.org> <20121210083342.GA31670@hacker.(null)> <50C5A62A.6030401@huawei.com> <1355136423.1700.2.camel@kernel.cn.ibm.com> <50C5C4A2.2070002@huawei.com> <20121210153805.GS16230@one.firstfloor.org> <50C6997C.1080702@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50C6997C.1080702@huawei.com> Sender: owner-linux-mm@kvack.org List-ID: To: Xishi Qiu Cc: Andi Kleen , Simon Jeons , Wanpeng Li , Andrew Morton , WuJianguo , Liujiang , Vyacheslav.Dubeyko@huawei.com, Borislav Petkov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, wency@cn.fujitsu.com, Hanjun Guo On Tue, Dec 11, 2012 at 10:25:00AM +0800, Xishi Qiu wrote: > On 2012/12/10 23:38, Andi Kleen wrote: > > >> It is another topic, I mean since the page is poisoned, so why not isolate it > >> from page buddy alocator in soft_offline_page() rather than in check_new_page(). > >> I find soft_offline_page() only migrate the page and mark HWPoison, the poisoned > >> page is still managed by page buddy alocator. > > > > Doing it in check_new_page is the only way if the page is currently > > allocated by someone. Since that's not uncommon it's simplest to always > > do it this way. > > > > -Andi > > > > Hi Andi, > > The poisoned page is isolated in check_new_page, however the whole buddy block will > be dropped, it seems to be a waste of memory. > > Can we separate the poisoned page from the buddy block, then *only* drop the poisoned > page? That sounds like overkill. There are not so many free pages in a typical server system. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org