From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: akpm@linux-foundation.org, aarcange@redhat.com,
rientjes@google.com, linux-mm@kvack.org
Subject: Re: [PATCH] huge_memory: fix huge zero page refcount
Date: Wed, 12 Dec 2012 12:51:09 +0200 [thread overview]
Message-ID: <20121212105109.GA14101@otc-wbsnb-06> (raw)
In-Reply-To: <1355294677-26842-1-git-send-email-lliubbo@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2495 bytes --]
On Wed, Dec 12, 2012 at 02:44:37PM +0800, Bob Liu wrote:
> Hi Andrew,
>
> It seems patch "[PATCH v5 10/11] thp: implement refcounting for huge zero
> page" was merged wrong into your tree.
>
> In Kirill's patch, put_huge_zero_page() is called in
> do_huge_pmd_wp_zero_page_fallback().
> But in linux-next and linux-mmotm.git, it's called in
> do_huge_pmd_wp_page_fallback().
>
> That's wrong and make below BUG triggered again:
>
> [ 1384.485993] ------------[ cut here ]------------
> [ 1384.486031] kernel BUG at mm/huge_memory.c:213!
> [ 1384.486055] invalid opcode: 0000 [#1] PREEMPT SMP
> .....
> 3.7.0-rc8+ #53 Dell Inc. OptiPlex 760 /0M860N
> [ 1384.486473] EIP: 0060:[<c114d9d8>] EFLAGS: 00010202 CPU: 1
> [ 1384.486504] EIP is at put_huge_zero_page+0x18/0x20
> [ 1384.486528] EAX: 00000001 EBX: 00000008 ECX: 00000000 EDX: ed5c4000
> [ 1384.486556] ESI: b5a00000 EDI: ed7af000 EBP: ed5c5e8c ESP: ed5c5e8c
> [ 1384.486585] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
> [ 1384.486611] CR0: 8005003b CR2: b59ffba8 CR3: 2e79a000 CR4: 000427f0
> [ 1384.486639] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
> [ 1384.486668] DR6: ffff0ff0 DR7: 00000400
> [ 1384.486687] Process gnome-terminal (pid: 12714, ti=ed5c4000 task=ebd59a60
> task.ti=ed5c4000)
> [ 1384.486724] Stack:
> [ 1384.486735] ed5c5eec c1151329 092fb067 80000000 eaf9eca8 ed7ae800 ed7ae800
> 2c6f9000
> [ 1384.486786] 00000000 f5ff16e8 f251d378 00000163 b5a00000 f4622000 b5800000
> f251d340
> [ 1384.486836] ec7b6c60 80000000 092fb067 2c6f9067 00000000 c74000c5 80000000
> eaf9ed60
> [ 1384.486887] Call Trace:
> [ 1384.486902] [<c1151329>] do_huge_pmd_wp_page+0x949/0xb60
> [ 1384.486929] [<c1128aff>] handle_mm_fault+0x14f/0x330
> [ 1384.486956] [<c1804810>] ? __do_page_fault+0x550/0x550
> [ 1384.486981] [<c180440d>] __do_page_fault+0x14d/0x550
> [ 1384.487005] [<c180481d>] ? do_page_fault+0xd/0x10
> [ 1384.487030] [<c1801cdf>] ? error_code+0x67/0x6c
> [ 1384.487054] [<c180007b>] ? __schedule+0x66b/0x7c0
> [ 1384.487080] [<c12ea155>] ? __put_user_4+0x11/0x18
> [ 1384.487104] [<c1804810>] ? __do_page_fault+0x550/0x550
> [ 1384.487130] [<c180481d>] do_page_fault+0xd/0x10
> [ 1384.487153] [<c1801cdf>] error_code+0x67/0x6c
> [ 1384.487176] [<c1800000>] ? __schedule+0x5f0/0x7c0
>
> Signed-off-by: Bob Liu <lliubbo@gmail.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-12-12 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 6:44 [PATCH] huge_memory: fix huge zero page refcount Bob Liu
2012-12-12 10:51 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212105109.GA14101@otc-wbsnb-06 \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).