From: Michal Hocko <mhocko@suse.cz>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 5/8] mm: vmscan: improve comment on low-page cache handling
Date: Thu, 13 Dec 2012 17:07:42 +0100 [thread overview]
Message-ID: <20121213160742.GH21644@dhcp22.suse.cz> (raw)
In-Reply-To: <1355348620-9382-6-git-send-email-hannes@cmpxchg.org>
On Wed 12-12-12 16:43:37, Johannes Weiner wrote:
> Fix comment style and elaborate on why anonymous memory is
> force-scanned when file cache runs low.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
yes, much better
Reviewed-by: Michal Hocko <mhocko@suse.cz>
> ---
> mm/vmscan.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 5e1beed..05475e1 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1697,13 +1697,15 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
> file = get_lru_size(lruvec, LRU_ACTIVE_FILE) +
> get_lru_size(lruvec, LRU_INACTIVE_FILE);
>
> + /*
> + * If it's foreseeable that reclaiming the file cache won't be
> + * enough to get the zone back into a desirable shape, we have
> + * to swap. Better start now and leave the - probably heavily
> + * thrashing - remaining file pages alone.
> + */
> if (global_reclaim(sc)) {
> - free = zone_page_state(zone, NR_FREE_PAGES);
> + free = zone_page_state(zone, NR_FREE_PAGES);
> if (unlikely(file + free <= high_wmark_pages(zone))) {
> - /*
> - * If we have very few page cache pages, force-scan
> - * anon pages.
> - */
> fraction[0] = 1;
> fraction[1] = 0;
> denominator = 1;
> --
> 1.7.11.7
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-12-13 16:07 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 21:43 [patch 0/8] page reclaim bits Johannes Weiner
2012-12-12 21:43 ` [patch 1/8] mm: memcg: only evict file pages when we have plenty Johannes Weiner
2012-12-12 21:53 ` Rik van Riel
2012-12-12 22:28 ` Johannes Weiner
2012-12-13 10:07 ` Mel Gorman
2012-12-13 14:44 ` Mel Gorman
2012-12-13 14:55 ` Michal Hocko
2012-12-16 1:21 ` Simon Jeons
2012-12-17 15:54 ` Michal Hocko
2012-12-19 5:21 ` Simon Jeons
2012-12-19 9:20 ` Mel Gorman
2012-12-13 5:36 ` Simon Jeons
2012-12-13 5:34 ` Simon Jeons
2012-12-12 21:43 ` [patch 2/8] mm: vmscan: disregard swappiness shortly before going OOM Johannes Weiner
2012-12-12 22:01 ` Rik van Riel
2012-12-13 5:56 ` Simon Jeons
2012-12-13 10:34 ` Mel Gorman
2012-12-13 15:29 ` Michal Hocko
2012-12-13 16:05 ` Michal Hocko
2012-12-13 22:25 ` Satoru Moriya
2012-12-14 4:50 ` Johannes Weiner
2012-12-14 8:37 ` Michal Hocko
2012-12-14 15:43 ` Rik van Riel
2012-12-14 16:13 ` Michal Hocko
2012-12-15 0:18 ` Johannes Weiner
2012-12-17 16:37 ` Michal Hocko
2012-12-17 17:54 ` Johannes Weiner
2012-12-17 19:58 ` Michal Hocko
2012-12-14 20:17 ` Satoru Moriya
2012-12-14 19:44 ` Satoru Moriya
2012-12-13 19:05 ` Johannes Weiner
2012-12-13 19:47 ` Mel Gorman
2012-12-12 21:43 ` [patch 3/8] mm: vmscan: save work scanning (almost) empty LRU lists Johannes Weiner
2012-12-12 22:02 ` Rik van Riel
2012-12-13 10:41 ` Mel Gorman
2012-12-13 19:33 ` Johannes Weiner
2012-12-13 15:43 ` Michal Hocko
2012-12-13 19:38 ` Johannes Weiner
2012-12-14 8:46 ` Michal Hocko
2012-12-12 21:43 ` [patch 4/8] mm: vmscan: clarify LRU balancing close to OOM Johannes Weiner
2012-12-12 22:03 ` Rik van Riel
2012-12-13 10:46 ` Mel Gorman
2012-12-12 21:43 ` [patch 5/8] mm: vmscan: improve comment on low-page cache handling Johannes Weiner
2012-12-12 22:04 ` Rik van Riel
2012-12-13 10:47 ` Mel Gorman
2012-12-13 16:07 ` Michal Hocko [this message]
2012-12-12 21:43 ` [patch 6/8] mm: vmscan: clean up get_scan_count() Johannes Weiner
2012-12-12 22:06 ` Rik van Riel
2012-12-13 11:07 ` Mel Gorman
2012-12-13 16:18 ` Michal Hocko
2012-12-12 21:43 ` [patch 7/8] mm: vmscan: compaction works against zones, not lruvecs Johannes Weiner
2012-12-12 22:31 ` Rik van Riel
2012-12-13 11:12 ` Mel Gorman
2012-12-13 16:48 ` Michal Hocko
2012-12-12 21:43 ` [patch 8/8] mm: reduce rmap overhead for ex-KSM page copies created on swap faults Johannes Weiner
2012-12-12 22:34 ` Rik van Riel
2012-12-12 21:50 ` [patch 0/8] page reclaim bits Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121213160742.GH21644@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).