From: Mel Gorman <mgorman@suse.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Minchan Kim <minchan@kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: compaction: count compaction events only if compaction is enabled
Date: Thu, 20 Dec 2012 10:52:14 +0000 [thread overview]
Message-ID: <20121220105214.GC10819@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1212201118080.17797@pobox.suse.cz>
On Thu, Dec 20, 2012 at 11:21:34AM +0100, Jiri Kosina wrote:
> On configs which have CONFIG_CMA but no CONFIG_COMPACTION,
> isolate_migratepages_range() and isolate_freepages_block() must not
> account for COMPACTFREE_SCANNED and COMPACTISOLATED events (those
> constants are even undefined in such case, causing a build error).
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Minchan has a similar patch in the works that defines count_compact_events()
similar to count_vm_numa_events(). It just needs a small correction. The
fixed version would avoid having an #ifdef in the middle of the function
which is cosmetically a bit nicer.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-12-20 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 10:21 [PATCH] mm: compaction: count compaction events only if compaction is enabled Jiri Kosina
2012-12-20 10:52 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220105214.GC10819@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).