From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA3C5C64EC4 for ; Wed, 8 Mar 2023 16:05:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57BBF6B0072; Wed, 8 Mar 2023 11:05:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52919280001; Wed, 8 Mar 2023 11:05:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F0726B0075; Wed, 8 Mar 2023 11:05:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2F0406B0072 for ; Wed, 8 Mar 2023 11:05:44 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 008F3A0D73 for ; Wed, 8 Mar 2023 16:05:43 +0000 (UTC) X-FDA: 80546206566.02.B7A5776 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 511DB10018E for ; Wed, 8 Mar 2023 16:04:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KcaP2lLK; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678291488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2NWMkFGTVgULUDjAwqmBVEBtedj5eFLtnY35SqecmsU=; b=UNWZFBTmlLpLoB6qI8IlS8UicNmaiXG5N2S/TqJd3OyzXTny/v79Xf9ll8eOwrRjrInAXU lP97AeVTVYog7vyHODiMwmNmjPNZfNq91TcRe1S7c56YUrR6ziSzYPb3+Y/diCyR0mgtz5 cmKeVJL51y2K7upo3fn9oknx9j8VeZA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KcaP2lLK; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678291488; a=rsa-sha256; cv=none; b=Dzok5Yv+oFbwmikzDDV6nlWtr31EK3/5msfnwLza/76j/ruk9Ib+pq0yvr77/kDh32Oawu 0EmRSHrZr1bpOIPjhlqZu43fXZ4DOV+cVHRKisiXHYXVTZKFzYfeL4DSG51oyMkhtHEaG9 kOgxln+jj4igQ5iwFLrPTRNvrAYVZso= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678291487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2NWMkFGTVgULUDjAwqmBVEBtedj5eFLtnY35SqecmsU=; b=KcaP2lLKfOTGjMraSSXdwu1lKXH3bW3A9IsQTYpnOP95XWuSVN/n4L7I6PMysCXYsOoR3F B2HnO3Qmjmk1Pc2o7ywQ6L3nnaKVSF24NPRZqSQLhzW3SPtLJUCab9AGJdF6qr0E7VjveO pQcks62wwmRl7puGnSSxiV3EFkuacwo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-sBNcmhvQO3ucJLvWDaxBBQ-1; Wed, 08 Mar 2023 11:04:43 -0500 X-MC-Unique: sBNcmhvQO3ucJLvWDaxBBQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 384B687B2A6; Wed, 8 Mar 2023 16:04:42 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id C38C42026D4B; Wed, 8 Mar 2023 16:04:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230308155609.GA21508@lst.de> References: <20230308155609.GA21508@lst.de> <20230308143754.1976726-1-dhowells@redhat.com> <20230308143754.1976726-4-dhowells@redhat.com> <2011735.1678290876@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Miklos Szeredi , Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v16 03/13] overlayfs: Implement splice-read MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2012342.1678291479.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 08 Mar 2023 16:04:39 +0000 Message-ID: <2012343.1678291479@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 511DB10018E X-Rspam-User: X-Stat-Signature: or5p3tsm63st3p1smwudydwj18ibm8k5 X-HE-Tag: 1678291488-163435 X-HE-Meta: U2FsdGVkX1/zLYKnfqBjDfgqmMnuYjQQmJzAzdEuPM+uEQezCgtgDv5nNdXdaf/xq7Xw4MweTsnp3ECSxj0+csaQPSJRB09DZDBdckTDM9UVGLq73tH8X2xkilf62pfkxacURs5YAHFZ9oNhcgx1tiyH3Ao9pyopoBk80xa3oaV+/osvG2RLFnK9BLHmv4HTthstruQl3Z1ZwHJpODLiFEvavSB+per5Q1Fu65XP/cCHKVuyQa5W8FhWLmL03I1GhptGSViERD/MhobEGncwZHFSUDBlfpuErFQ35jip2ViDSiHQsfJg95w0GdEGH0zhzRcsZnhJvxolI3N7KDHI/gONuJH9o/0YVoMlAh2nAspsRaqATBMMMlQIeP7ZM2rxQzMlZpVlDU1tdwRbmJ0tKjI58tgjSIFYLbdMChxVv/VwmFlO7n3oHB4kp9KazcVAprNurAiAwzOeL+gXqJt+/kJI5XQoWk5t5zMfFbJfJgotJkWwzj7btSrsxi04SXWVSvuz0+F2BRm2KeggGqVxW7d8m6kVT8Zk/+2vCz+X1itSaXjeyixmb7ehcErMhdvUhstjLSzNOhIdU+heQEURcS3do0WHPAdWtQIIZR9Tl2t27R0iWR/I4ruDCSFdRNOXiX2+XSA+GorXDXkRRxkr7Gq509C1FOBl0qQII90s1eiuTnsiiAjNBf7LRuefObTCpZwozjXJLJ7ylvpcPseyZwSsIYB7inNKtiCI6HoSpWVn3itIpzbiuTmaQatvHwcfz4A3F+6G4DvL2Qh6UFJ7x3+XQDX0XyGFQVAJ7pUSvR/eShcXQgltph8aME2THS9Npa01WycSV5az0cH4hjnarCHmJenIpE3jCHwmF6/8EXsz4ayX+kolM7R6nE51Rsm8tsFHKe0acDhYRd92DrSJnKtnGg8CrLXJpYaSASku4VXQZd+2XuSTdYrJIbdI5nSbyYAMt/ilK29JxIra4Nj Zgc6Ki5r lFf5NqyYxV8f7J35PSv/13jb1urVzVWf6cUQjCIN+xH5v2/ThQ7w1nyGpmmCxIknSL4b56SLmn/tN4X+WjtKBU2RtqbBSSZSYQpproNsVMdJ2h9swHG2NOtCB1IsRpJieUYgb1ci5082v1ZlKAHIU/wd/nbkMWR+oWaL7VdnUsFTlJ1A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christoph Hellwig wrote: > On Wed, Mar 08, 2023 at 03:54:36PM +0000, David Howells wrote: > > Using do_splice_to() as a helper is probably a good idea, though both = Willy > > and Christoph seem to dislike it. > = > That's not true. What I'm fundamentlly against is pointless wrappers > like the call_* that add no value. do_splice_to adds useful checks, > so if properly named and documented, I'm absolutely in favour. Fair enough. Rename to vfs_splice_read() okay with you? David