From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx116.postini.com [74.125.245.116]) by kanga.kvack.org (Postfix) with SMTP id 4D1F56B0071 for ; Wed, 2 Jan 2013 21:29:15 -0500 (EST) Received: by mail-qa0-f53.google.com with SMTP id a19so9369483qad.5 for ; Wed, 02 Jan 2013 18:29:14 -0800 (PST) Date: Wed, 2 Jan 2013 21:29:11 -0500 From: Tejun Heo Subject: Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach() Message-ID: <20130103022911.GH11220@mtj.dyndns.org> References: <1354138460-19286-1-git-send-email-tj@kernel.org> <1354138460-19286-7-git-send-email-tj@kernel.org> <50DACF5B.6050705@huawei.com> <20121226120415.GA18193@mtj.dyndns.org> <87zk0s5h7c.fsf@rustcorp.com.au> <20130102153439.GA11220@mtj.dyndns.org> <871ue35bzk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871ue35bzk.fsf@rustcorp.com.au> Sender: owner-linux-mm@kvack.org List-ID: To: Rusty Russell Cc: Li Zefan , paul@paulmenage.org, glommer@parallels.com, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, peterz@infradead.org, mhocko@suse.cz, bsingharora@gmail.com, hannes@cmpxchg.org, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Hello, Rusty. On Thu, Jan 03, 2013 at 11:17:11AM +1030, Rusty Russell wrote: > > So, I guess this currently is caught in a place which isn't here or > > there. I'm pretty skeptical whether it makes sense to bother about > > static usages tho. Can I keep them for static ones? > > I didn't realize that cpuset_attach was a fastpath. If it is, put a It isn't a hot path. It's just a bit nasty to have to allocate them separately. > static there and I'll fix turn it into a bitmap when I need to. > Otherwise, please don't change the code in the first place. So, the plan to drop cpumask_t is still on? If so, I'll leave cpumask_var_t. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org