From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Lin Feng <linfeng@cn.fujitsu.com>
Cc: akpm@linux-foundation.org, tj@kernel.org, mingo@kernel.org,
yinghai@kernel.org, benh@kernel.crashing.org,
tangchen@cn.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm: memblock: fix wrong memmove size in memblock_merge_regions()
Date: Sat, 5 Jan 2013 09:04:20 +0800 [thread overview]
Message-ID: <20130105010420.GA26319@hacker.(null)> (raw)
In-Reply-To: <1357290650-25544-1-git-send-email-linfeng@cn.fujitsu.com>
On Fri, Jan 04, 2013 at 05:10:50PM +0800, Lin Feng wrote:
>The memmove span covers from (next+1) to the end of the array, and the index
>of next is (i+1), so the index of (next+1) is (i+2). So the size of remaining
>array elements is (type->cnt - (i + 2)).
>
Make sense.
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>PS. It seems that memblock_merge_regions() could be made some improvement:
>we need't memmove the remaining array elements until we find a none-mergable
>element, but now we memmove everytime we find a neighboring compatible region.
>I'm not sure if the trial is worth though.
>
>Cc: Tejun Heo <tj@kernel.org>
>Signed-off-by: Lin Feng <linfeng@cn.fujitsu.com>
>---
> mm/memblock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/memblock.c b/mm/memblock.c
>index 6259055..85ce056 100644
>--- a/mm/memblock.c
>+++ b/mm/memblock.c
>@@ -314,7 +314,7 @@ static void __init_memblock memblock_merge_regions(struct memblock_type *type)
> }
>
> this->size += next->size;
>- memmove(next, next + 1, (type->cnt - (i + 1)) * sizeof(*next));
>+ memmove(next, next + 1, (type->cnt - (i + 2)) * sizeof(*next));
> type->cnt--;
> }
> }
>--
>1.7.11.7
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-05 1:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 9:10 [RFC PATCH] mm: memblock: fix wrong memmove size in memblock_merge_regions() Lin Feng
2013-01-04 14:56 ` Tejun Heo
2013-01-07 1:29 ` Lin Feng
2013-01-05 1:04 ` Wanpeng Li [this message]
2013-01-07 1:31 ` Lin Feng
2013-01-05 1:04 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130105010420.GA26319@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=tangchen@cn.fujitsu.com \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).