From: Mel Gorman <mgorman@suse.de>
To: Cliff Wickman <cpw@sgi.com>
Cc: aarcange@redhat.com, akpm@linux-foundation.org, avi@redhat.com,
hughd@google.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm: export mmu notifier invalidates
Date: Mon, 7 Jan 2013 14:14:46 +0000 [thread overview]
Message-ID: <20130107141446.GF3885@suse.de> (raw)
In-Reply-To: <E1Tr9P7-0001AN-S4@eag09.americas.sgi.com>
On Fri, Jan 04, 2013 at 09:41:53AM -0600, Cliff Wickman wrote:
> From: Cliff Wickman <cpw@sgi.com>
>
> Avi, Andrea, Andrew, Hugh, Mel,
>
> We at SGI have a need to address some very high physical address ranges with
> our GRU (global reference unit), sometimes across partitioned machine boundaries
> and sometimes with larger addresses than the cpu supports.
> We do this with the aid of our own 'extended vma' module which mimics the vma.
> When something (either unmap or exit) frees an 'extended vma' we use the mmu
> notifiers to clean them up.
>
> We had been able to mimic the functions __mmu_notifier_invalidate_range_start()
> and __mmu_notifier_invalidate_range_end() by locking the per-mm lock and
> walking the per-mm notifier list. But with the change to a global srcu
> lock (static in mmu_notifier.c) we can no longer do that. Our module has
> no access to that lock.
>
> So we request that these two functions be exported.
>
I do not believe I wrote any of the MMU notifier code so it's not up to
me how it should be exported (or if it should even be allowed). I find it
curious that it appears that no other driver needs this and wonder if you
could also abuse the vma_ops->close interface to do some of the cleanup
but I've no idea what your module is doing. I've no objection to the
export as such but it's really not my call.
Andrea?
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-07 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 15:41 [PATCH] mm: export mmu notifier invalidates Cliff Wickman
2013-01-04 21:35 ` Christoph Hellwig
2013-01-04 22:09 ` Cliff Wickman
2013-01-07 14:14 ` Mel Gorman [this message]
2013-01-07 15:35 ` Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2013-02-12 21:35 Cliff Wickman
2013-02-12 21:57 ` Andrew Morton
2013-02-13 15:03 ` Robin Holt
2013-02-13 20:11 ` Andrew Morton
2013-02-13 21:03 ` Robin Holt
2013-02-14 21:08 ` Andrew Morton
2013-02-14 21:35 ` Robin Holt
2013-02-14 21:52 ` Andrew Morton
2013-02-14 22:25 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107141446.GF3885@suse.de \
--to=mgorman@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=cpw@sgi.com \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).