From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Hillf Danton <dhillf@gmail.com>, Hugh Dickins <hughd@google.com>,
Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Linux-MM <linux-mm@kvack.org>,
Rik van Riel <riel@redhat.com>
Subject: Re: oops in copy_page_rep()
Date: Tue, 8 Jan 2013 20:03:02 +0200 [thread overview]
Message-ID: <20130108180302.GA27871@shutemov.name> (raw)
In-Reply-To: <20130108174951.GG9163@redhat.com>
On Tue, Jan 08, 2013 at 06:49:51PM +0100, Andrea Arcangeli wrote:
> Hi Kirill,
>
> On Tue, Jan 08, 2013 at 07:30:58PM +0200, Kirill A. Shutemov wrote:
> > Merged patch is obviously broken: huge_pmd_set_accessed() can be called
> > only if the pmd is under splitting.
>
> Of course I assume you meant "only if the pmd is not under splitting".
The broken merged patch has this:
+ if (dirty && !pmd_write(orig_pmd) &&
!pmd_trans_splitting(orig_pmd)) {
[...]
+ } else {
+ huge_pmd_set_accessed(mm, vma, address, pmd,
+ orig_pmd, dirty);
}
> But no, setting a bitflag like the young bit or clearing or setting
> the numa bit won't screw with split_huge_page and it's safe even if
> the pmd is under splitting.
Okay. Thanks for clarification for me.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-08 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130105152208.GA3386@redhat.com>
[not found] ` <CAJd=RBCb0oheRnVCM4okVKFvKGzuLp9GpZJCkVY3RR-J=XEoBA@mail.gmail.com>
[not found] ` <alpine.LNX.2.00.1301061037140.28950@eggly.anvils>
[not found] ` <CAJd=RBAps4Qk9WLYbQhLkJd8d12NLV0CbjPYC6uqH_-L+Vu0VQ@mail.gmail.com>
[not found] ` <CA+55aFyYAf6ztDLsxWFD+6jb++y0YNjso-9j+83Mm+3uQ=8PdA@mail.gmail.com>
2013-01-08 13:04 ` oops in copy_page_rep() Hillf Danton
2013-01-08 15:37 ` Linus Torvalds
2013-01-08 16:31 ` Kirill A. Shutemov
2013-01-08 16:52 ` Linus Torvalds
2013-01-08 17:30 ` Kirill A. Shutemov
2013-01-08 17:38 ` Linus Torvalds
2013-01-08 17:49 ` Andrea Arcangeli
2013-01-08 18:03 ` Kirill A. Shutemov [this message]
2013-01-11 7:50 ` Simon Jeons
2013-01-11 14:01 ` Andrea Arcangeli
2013-01-08 17:37 ` Andrea Arcangeli
2013-01-08 17:51 ` Linus Torvalds
2013-01-08 18:03 ` Andrea Arcangeli
2013-01-08 18:21 ` Linus Torvalds
2013-01-09 11:38 ` Hillf Danton
2013-01-09 4:23 ` Hugh Dickins
2013-01-09 11:44 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108180302.GA27871@shutemov.name \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).