From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Sonny Rao <sonnyrao@google.com>, Bryan Freed <bfreed@google.com>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/2] mm: prevent to add a page to swap if may_writepage is unset
Date: Wed, 9 Jan 2013 16:20:42 -0800 [thread overview]
Message-ID: <20130109162042.79a9fedd.akpm@linux-foundation.org> (raw)
In-Reply-To: <1357712474-27595-2-git-send-email-minchan@kernel.org>
On Wed, 9 Jan 2013 15:21:13 +0900
Minchan Kim <minchan@kernel.org> wrote:
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -780,6 +780,8 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> if (PageAnon(page) && !PageSwapCache(page)) {
> if (!(sc->gfp_mask & __GFP_IO))
> goto keep_locked;
> + if (!sc->may_writepage)
> + goto keep_locked;
> if (!add_to_swap(page))
> goto activate_locked;
> may_enter_fs = 1;
We should add a comment here explaining what's going on. But I can't
suggest anything which sounds rational because this looks so wrong :(
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-10 0:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 6:21 [PATCH 0/2] Use up free swap space before reaching OOM kill Minchan Kim
2013-01-09 6:21 ` [PATCH 1/2] mm: prevent to add a page to swap if may_writepage is unset Minchan Kim
2013-01-09 6:56 ` Johannes Weiner
2013-01-09 7:10 ` Minchan Kim
2013-01-10 0:18 ` Andrew Morton
2013-01-10 2:03 ` Minchan Kim
2013-01-10 23:24 ` Luigi Semenzato
2013-01-10 23:27 ` Luigi Semenzato
2013-01-11 4:03 ` Minchan Kim
2013-01-10 0:20 ` Andrew Morton [this message]
2013-01-16 21:41 ` Andrew Morton
2013-01-17 0:53 ` Minchan Kim
2013-01-17 22:22 ` Andrew Morton
2013-01-17 23:36 ` Minchan Kim
2013-01-21 1:52 ` Minchan Kim
2013-01-21 14:39 ` Rik van Riel
2013-01-22 0:09 ` Minchan Kim
2013-02-05 1:43 ` Minchan Kim
2013-01-09 6:21 ` [PATCH 2/2] mm: forcely swapout when we are out of page cache Minchan Kim
2013-01-10 0:26 ` Andrew Morton
2013-01-10 2:23 ` Minchan Kim
2013-01-10 21:58 ` Andrew Morton
2013-01-11 4:43 ` Minchan Kim
2013-01-16 0:09 ` Andrew Morton
2013-01-16 0:32 ` Sonny Rao
2013-01-16 0:50 ` Andrew Morton
2013-01-16 1:21 ` Sonny Rao
2013-01-16 4:47 ` Minchan Kim
2013-01-16 20:08 ` Sonny Rao
2013-01-16 4:43 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109162042.79a9fedd.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bfreed@google.com \
--cc=dan.magenheimer@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=sonnyrao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).