From: Liu Bo <bo.li.liu@oracle.com>
To: Zach Brown <zab@zabbo.net>
Cc: Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH] mm/slab: add a leak decoder callback
Date: Wed, 16 Jan 2013 09:02:30 +0800 [thread overview]
Message-ID: <20130116010229.GB3942@liubo> (raw)
In-Reply-To: <20130115170105.GP12288@lenny.home.zabbo.net>
On Tue, Jan 15, 2013 at 09:01:05AM -0800, Zach Brown wrote:
> > The merge processing occurs during kmem_cache_create and you are setting
> > up the decoder field afterwards! Wont work.
>
> In the thread I suggested providing the callback at destruction:
>
> http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg21130.html
>
> I liked that it limits accesibility of the callback to the only path
> that uses it.
Well, I was trying to avoid API change, but seems we have to, I'll
update the patch as your suggestion in the next version.
thanks,
liubo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-16 1:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 6:03 [PATCH] mm/slab: add a leak decoder callback Liu Bo
2013-01-15 16:30 ` Christoph Lameter
2013-01-15 17:01 ` Zach Brown
2013-01-16 1:02 ` Liu Bo [this message]
2013-01-16 0:59 ` Liu Bo
2013-01-19 9:11 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116010229.GB3942@liubo \
--to=bo.li.liu@oracle.com \
--cc=cl@linux.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).