From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx172.postini.com [74.125.245.172]) by kanga.kvack.org (Postfix) with SMTP id 667AA6B0002 for ; Tue, 22 Jan 2013 17:40:26 -0500 (EST) Date: Tue, 22 Jan 2013 14:40:24 -0800 From: Andrew Morton Subject: Re: [PATCH 3/6] mm: numa: Handle side-effects in count_vm_numa_events() for !CONFIG_NUMA_BALANCING Message-Id: <20130122144024.8ded0f53.akpm@linux-foundation.org> In-Reply-To: <1358874762-19717-4-git-send-email-mgorman@suse.de> References: <1358874762-19717-1-git-send-email-mgorman@suse.de> <1358874762-19717-4-git-send-email-mgorman@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Peter Zijlstra , Andrea Arcangeli , Ingo Molnar , Simon Jeons , Wanpeng Li , Hugh Dickins , Linux-MM , LKML On Tue, 22 Jan 2013 17:12:39 +0000 Mel Gorman wrote: > The current definitions for count_vm_numa_events() is wrong for > !CONFIG_NUMA_BALANCING as the following would miss the side-effect. > > count_vm_numa_events(NUMA_FOO, bar++); Stupid macros. > There are no such users of count_vm_numa_events() but it is a potential > pitfall. This patch fixes it and converts count_vm_numa_event() so that > the definitions look similar. Confused. The patch doesn't alter count_vm_numa_event(). No matter. > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -85,7 +85,7 @@ static inline void vm_events_fold_cpu(int cpu) > #define count_vm_numa_events(x, y) count_vm_events(x, y) > #else > #define count_vm_numa_event(x) do {} while (0) > -#define count_vm_numa_events(x, y) do {} while (0) > +#define count_vm_numa_events(x, y) do { (void)(y); } while (0) > #endif /* CONFIG_NUMA_BALANCING */ > > #define __count_zone_vm_events(item, zone, delta) \ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org