From: Jan Kara <jack@suse.cz>
To: paul.szabo@sydney.edu.au
Cc: linux-mm@kvack.org, 695182@bugs.debian.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAX_PAUSE to be at least 4
Date: Wed, 23 Jan 2013 01:01:47 +0100 [thread overview]
Message-ID: <20130123000147.GC7497@quack.suse.cz> (raw)
In-Reply-To: <201301210307.r0L37YuG018834@como.maths.usyd.edu.au>
On Mon 21-01-13 14:07:34, paul.szabo@sydney.edu.au wrote:
> Ensure MAX_PAUSE is 4 or larger, so limits in
> return clamp_val(t, 4, MAX_PAUSE);
> (the only use of it) are not back-to-front.
>
> (This patch does not solve the PAE OOM issue.)
>
> Paul Szabo psz@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/
> School of Mathematics and Statistics University of Sydney Australia
I guess this isn't needed in patch changelog?
Also clamp_val(t, 4, MAX_PAUSE) doesn't seem to exist anymore?
Honza
> Reported-by: Paul Szabo <psz@maths.usyd.edu.au>
> Reference: http://bugs.debian.org/695182
> Signed-off-by: Paul Szabo <psz@maths.usyd.edu.au>
>
> --- mm/page-writeback.c.old 2012-12-06 22:20:40.000000000 +1100
> +++ mm/page-writeback.c 2013-01-21 13:57:05.000000000 +1100
> @@ -39,7 +39,7 @@
> /*
> * Sleep at most 200ms at a time in balance_dirty_pages().
> */
> -#define MAX_PAUSE max(HZ/5, 1)
> +#define MAX_PAUSE max(HZ/5, 4)
>
> /*
> * Estimate write bandwidth at 200ms intervals.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-23 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 3:07 [PATCH] MAX_PAUSE to be at least 4 paul.szabo
2013-01-23 0:01 ` Jan Kara [this message]
2013-01-23 0:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123000147.GC7497@quack.suse.cz \
--to=jack@suse.cz \
--cc=695182@bugs.debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paul.szabo@sydney.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).