Re: block: optionally snapshot page contents to provide stable pages during write

Re: block: optionally snapshot page contents to provide stable pages during write

[Sedat Dilek]

Hi Darrick,

can you tell me why you do not put your help text where it normally
belongs ("help" Kconfig item)?

273 # We also use the bounce pool to provide stable page writes for jbd.  jbd
274 # initiates buffer writeback without locking the page or setting
PG_writeback,
275 # and fixing that behavior (a second time; jbd2 doesn't have this
problem) is
276 # a major rework effort.  Instead, use the bounce buffer to snapshot pages
277 # (until jbd goes away).  The only jbd user is ext3.
278 config NEED_BOUNCE_POOL
279         bool
280         default y if (TILE && USB_OHCI_HCD) || (BLK_DEV_INTEGRITY && JBD)
281         help
282         line #273..277

Noticed while hunting a culprit commit in Linux-Next as my
kernel-config got changed between next-20130123..next-20130124.

Regards,
- Sedat -

[1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=3f1c22e#patch5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: block: optionally snapshot page contents to provide stable pages during write

[Darrick J. Wong]

On Sat, Jan 26, 2013 at 01:39:46PM +0100, Sedat Dilek wrote:
> Hi Darrick,
> 
> can you tell me why you do not put your help text where it normally
> belongs ("help" Kconfig item)?

Sure -- the non-ISA bounce pool is only used by a small number of specific
parts of the kernel that require it.  If those parts aren't built, then forcing
it on causes a useless memory pool to be created, wasting memory.  Since kbuild
can figure out when we need it and when we don't, there's no need to present
the user with a config option that they can only use to do the wrong thing.

--D
> 
> 273 # We also use the bounce pool to provide stable page writes for jbd.  jbd
> 274 # initiates buffer writeback without locking the page or setting
> PG_writeback,
> 275 # and fixing that behavior (a second time; jbd2 doesn't have this
> problem) is
> 276 # a major rework effort.  Instead, use the bounce buffer to snapshot pages
> 277 # (until jbd goes away).  The only jbd user is ext3.
> 278 config NEED_BOUNCE_POOL
> 279         bool
> 280         default y if (TILE && USB_OHCI_HCD) || (BLK_DEV_INTEGRITY && JBD)
> 281         help
> 282         line #273..277
> 
> Noticed while hunting a culprit commit in Linux-Next as my
> kernel-config got changed between next-20130123..next-20130124.
> 
> Regards,
> - Sedat -
> 
> [1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=3f1c22e#patch5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>