From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx128.postini.com [74.125.245.128]) by kanga.kvack.org (Postfix) with SMTP id 1281C6B0007 for ; Sun, 27 Jan 2013 23:32:59 -0500 (EST) Date: Mon, 28 Jan 2013 13:32:57 +0900 From: Minchan Kim Subject: Re: [PATCHv2 6/9] zsmalloc: promote to lib/ Message-ID: <20130128043257.GH3321@blaptop> References: <1357590280-31535-1-git-send-email-sjenning@linux.vnet.ibm.com> <1357590280-31535-7-git-send-email-sjenning@linux.vnet.ibm.com> <20130128040116.GF3321@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130128040116.GF3321@blaptop> Sender: owner-linux-mm@kvack.org List-ID: To: Seth Jennings Cc: Greg Kroah-Hartman , Andrew Morton , Nitin Gupta , Konrad Rzeszutek Wilk , Dan Magenheimer , Robert Jennings , Jenifer Hopper , Mel Gorman , Johannes Weiner , Rik van Riel , Larry Woodman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org On Mon, Jan 28, 2013 at 01:01:16PM +0900, Minchan Kim wrote: > On Mon, Jan 07, 2013 at 02:24:37PM -0600, Seth Jennings wrote: > > This patch promotes the slab-based zsmalloc memory allocator > > from the staging tree to lib/ > > > > zswap depends on this allocator for storing compressed RAM pages > > in an efficient way under system wide memory pressure where > > high-order (greater than 0) page allocation are very likely to > > fail. > > > > For more information on zsmalloc and its internals, read the > > documentation at the top of the zsmalloc.c file. > > > > Signed-off-by: Seth Jennings > > Seth, zsmalloc has a bug[1], I sent a patch totay. If it want't known, > it mighte be no problem to promote but it's known bug so let's fix it > before promoting. > > Another question. Why do you promote zsmalloc in this patchset? > It might make you hard to merge even zswap into staging. When I look at [8/9], I realized you are trying to merge this patch into mm/, NOT staging. I don't know history why zsmalloc/zram/zscache was in staging at the beginning but personally, I don't ojbect zswap into /mm directly because I got realized staging is very deep hole to get out, expecially related to mm stuff. ;-) -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org