From: Minchan Kim <minchan@kernel.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Nitin Gupta <ngupta@vflare.org>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
stable@vger.kernel.org, Jerome Marchand <jmarchan@redhat.com>
Subject: Re: [RESEND PATCH v5 1/4] zram: Fix deadlock bug in partial write
Date: Tue, 29 Jan 2013 08:21:45 +0900 [thread overview]
Message-ID: <20130128232145.GA2666@blaptop> (raw)
In-Reply-To: <CAOJsxLFg_5uhZsvPmVVC0nnsZLGpkJ0W6mHa=aavmguLGuTTnA@mail.gmail.com>
On Mon, Jan 28, 2013 at 09:16:35AM +0200, Pekka Enberg wrote:
> On Mon, Jan 28, 2013 at 2:38 AM, Minchan Kim <minchan@kernel.org> wrote:
> > Now zram allocates new page with GFP_KERNEL in zram I/O path
> > if IO is partial. Unfortunately, It may cuase deadlock with
>
> s/cuase/cause/g
Thanks!
>
> > reclaim path so this patch solves the problem.
>
> It'd be nice to know about the problem in more detail. I'm also
> curious on why you decided on GFP_ATOMIC for the read path and
> GFP_NOIO in the write path.
In read path, we called kmap_atomic.
How about this?
------------------------- >8 -------------------------------
next prev parent reply other threads:[~2013-01-28 23:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 0:38 [RESEND PATCH v5 1/4] zram: Fix deadlock bug in partial write Minchan Kim
2013-01-28 0:38 ` [RESEND PATCH v5 2/4] zram: force disksize setting before using zram Minchan Kim
2013-01-28 0:38 ` [RESEND PATCH v5 3/4] zram: give up lazy initialization of zram metadata Minchan Kim
2013-01-28 0:38 ` [RESEND PATCH v5 4/4] zram: get rid of lockdep warning Minchan Kim
2013-01-28 7:16 ` [RESEND PATCH v5 1/4] zram: Fix deadlock bug in partial write Pekka Enberg
2013-01-28 11:24 ` Jerome Marchand
2013-01-28 13:26 ` Pekka Enberg
2013-01-28 13:47 ` Jerome Marchand
2013-01-28 23:21 ` Minchan Kim [this message]
2013-01-29 7:11 ` Pekka Enberg
2013-01-30 1:32 ` Minchan Kim
2013-01-30 4:20 ` Greg Kroah-Hartman
2013-01-30 8:21 ` Minchan Kim
2013-01-31 5:41 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128232145.GA2666@blaptop \
--to=minchan@kernel.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmarchan@redhat.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=penberg@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).