From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx150.postini.com [74.125.245.150]) by kanga.kvack.org (Postfix) with SMTP id 8DC686B0005 for ; Fri, 1 Feb 2013 09:04:48 -0500 (EST) Date: Fri, 1 Feb 2013 14:02:18 +0000 From: Russell King - ARM Linux Subject: Re: [PATCH] zsmalloc: Fix TLB coherency and build problem Message-ID: <20130201140218.GN23505@n2100.arm.linux.org.uk> References: <1359334808-19794-1-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1359334808-19794-1-git-send-email-minchan@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Greg Kroah-Hartman , Matt Sealey , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dan Magenheimer , Konrad Rzeszutek Wilk , Nitin Gupta , Seth Jennings On Mon, Jan 28, 2013 at 10:00:08AM +0900, Minchan Kim wrote: > @@ -663,7 +661,7 @@ static inline void __zs_unmap_object(struct mapping_area *area, > > flush_cache_vunmap(addr, end); > unmap_kernel_range_noflush(addr, PAGE_SIZE * 2); > - local_flush_tlb_kernel_range(addr, end); > + flush_tlb_kernel_range(addr, end); void unmap_kernel_range_noflush(unsigned long addr, unsigned long size) { vunmap_page_range(addr, addr + size); } void unmap_kernel_range(unsigned long addr, unsigned long size) { unsigned long end = addr + size; flush_cache_vunmap(addr, end); vunmap_page_range(addr, end); flush_tlb_kernel_range(addr, end); } So, given the above, what would be different between: unsigned long end = addr + (PAGE_SIZE * 2); flush_cache_vunmap(addr, end); unmap_kernel_range_noflush(addr, PAGE_SIZE * 2); flush_tlb_kernel_range(addr, end); (which is what it becomes after your change) and unmap_kernel_range(addr, PAGE_SIZE * 2); ? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org