linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [slab:slab/next 11/13] mm/slab_common.c:385:13: sparse: restricted gfp_t degrades to integer
Date: Sat, 2 Feb 2013 20:59:52 +0800	[thread overview]
Message-ID: <20130202125952.GE16114@localhost> (raw)
In-Reply-To: <0000013c971ab472-8542127a-19e8-4f6a-8b7e-5f5ab8bcd8fd-000000@email.amazonses.com>

On Fri, Feb 01, 2013 at 06:52:55PM +0000, Christoph Lameter wrote:
> On Fri, 1 Feb 2013, kbuild test robot wrote:
> 
> >    374		int index;
> >    375
> >    376		if (size <= 192) {
> >    377			if (!size)
> >    378				return ZERO_SIZE_PTR;
> >    379
> >    380			index = size_index[size_index_elem(size)];
> >    381		} else
> >    382			index = fls(size - 1);
> >    383
> >    384	#ifdef CONFIG_ZONE_DMA
> >  > 385		if (unlikely((flags & SLAB_CACHE_DMA)))
> 
> Should flags be cast to integer before doing the & operation?

It seems not easy to quiet this warning..

(unsigned long)flags & SLAB_CACHE_DMA
/c/wfg/sound/mm/slab_common.c:385:13: sparse: cast from restricted gfp_t

flags & (gfp_t)SLAB_CACHE_DMA
/c/wfg/sound/mm/slab_common.c:385:13: sparse: cast to restricted gfp_t

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

       reply	other threads:[~2013-02-02 12:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <510bae53.+nWBFPQ3bGiTzPs/%fengguang.wu@intel.com>
     [not found] ` <0000013c971ab472-8542127a-19e8-4f6a-8b7e-5f5ab8bcd8fd-000000@email.amazonses.com>
2013-02-02 12:59   ` Fengguang Wu [this message]
2013-02-04 14:46     ` [PATCH for-next] mm/sl[au]b: correct allocation type check in kmalloc_slab() Joonsoo Kim
2013-02-04 19:00       ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130202125952.GE16114@localhost \
    --to=fengguang.wu@intel.com \
    --cc=cl@linux.com \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).