linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Nitin Gupta <ngupta@vflare.org>,
	Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Konrad Rzeszutek Wilk <konrad@darnok.org>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	jmarchan@redhat.com
Subject: Re: [PATCH v6 4/4] zram: get rid of lockdep warning
Date: Mon, 4 Feb 2013 12:42:08 +0900	[thread overview]
Message-ID: <20130204034208.GF2688@blaptop> (raw)
In-Reply-To: <20130204015333.GA6548@kroah.com>

Hi Greg,

On Sun, Feb 03, 2013 at 05:53:33PM -0800, Greg Kroah-Hartman wrote:
> On Wed, Jan 30, 2013 at 11:41:42AM +0900, Minchan Kim wrote:
> > Lockdep complains about recursive deadlock of zram->init_lock.
> > [1] made it false positive because we can't request IO to zram
> > before setting disksize. Anyway, we should shut lockdep up to
> > avoid many reporting from user.
> > 
> > [1] : zram: force disksize setting before using zram
> > 
> > Acked-by: Jerome Marchand <jmarchand@redhat.com>
> > Acked-by: Nitin Gupta <ngupta@vflare.org>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
> >  drivers/staging/zram/zram_drv.c   |  189 +++++++++++++++++++------------------
> >  drivers/staging/zram/zram_drv.h   |   12 ++-
> >  drivers/staging/zram/zram_sysfs.c |   11 ++-
> >  3 files changed, 116 insertions(+), 96 deletions(-)
> 
> This patch fails to apply to my staging-next branch, but the three
> others did, so I took them.  Please refresh this one and resend if you
> want it applied.

We must have missed each other.
A few hours ago, I sent to you v7 based on next-20130202.
https://lkml.org/lkml/2013/2/3/319

v7 includes acks of Jerome and resolve conflict with latest staging.
I believe it is okay to apply your tree.

Please reapply v7 instead of v6.

Thanks.
> 
> thanks,
> 
> greg k-h
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-02-04  3:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30  2:41 [PATCH v6 1/4] zram: Fix deadlock bug in partial read/write Minchan Kim
2013-01-30  2:41 ` [PATCH v6 2/4] zram: force disksize setting before using zram Minchan Kim
2013-01-30  2:41 ` [PATCH v6 3/4] zram: give up lazy initialization of zram metadata Minchan Kim
2013-01-30  2:41 ` [PATCH v6 4/4] zram: get rid of lockdep warning Minchan Kim
2013-02-04  1:53   ` Greg Kroah-Hartman
2013-02-04  3:42     ` Minchan Kim [this message]
2013-02-04  3:50       ` Greg Kroah-Hartman
2013-02-04  3:58         ` Minchan Kim
2013-01-30 15:12 ` [PATCH v6 1/4] zram: Fix deadlock bug in partial read/write Jerome Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130204034208.GF2688@blaptop \
    --to=minchan@kernel.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jmarchan@redhat.com \
    --cc=konrad@darnok.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).