From: Andrew Morton <akpm@linux-foundation.org>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: break circular include from linux/mmzone.h
Date: Tue, 5 Feb 2013 13:18:01 -0800 [thread overview]
Message-ID: <20130205131801.131dabb1.akpm@linux-foundation.org> (raw)
In-Reply-To: <1360043796.4449.24.camel@liguang.fnst.cn.fujitsu.com>
On Tue, 05 Feb 2013 13:56:36 +0800
li guang <lig.fnst@cn.fujitsu.com> wrote:
> ___ 2013-02-04______ 21:20 -0800___David Rientjes_________
> > On Tue, 5 Feb 2013, liguang wrote:
> >
> > > linux/mmzone.h included linux/memory_hotplug.h,
> > > and linux/memory_hotplug.h also included
> > > linux/mmzone.h, so there's a bad cirlular.
> > >
> >
> > And both of these are protected by _LINUX_MMZONE_H and
> > __LINUX_MEMORY_HOTPLUG_H, respectively, so what's the problem?
>
> obviously, It's a logical error,
> and It has no more effect other than
> combination of these 2 header files.
> so, why don't we separate them?
>
Yup, flattening the hierarchy is nice. And having headers doing mutual
inclusion like this is Just Weird.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-05 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 4:15 [PATCH] mm: break circular include from linux/mmzone.h liguang
2013-02-05 5:20 ` David Rientjes
2013-02-05 5:56 ` li guang
2013-02-05 21:18 ` Andrew Morton [this message]
2013-02-06 18:15 ` [patch] mm: break circular include from linux/mmzone.h fix fix fix fix David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205131801.131dabb1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=lig.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).