From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx153.postini.com [74.125.245.153]) by kanga.kvack.org (Postfix) with SMTP id 50F026B0034 for ; Tue, 5 Feb 2013 20:54:20 -0500 (EST) Date: Tue, 5 Feb 2013 17:58:02 -0800 From: Andrew Morton Subject: Re: [PATCH 0/3] mm: rename confusing function names Message-Id: <20130205175802.2c62c826.akpm@linux-foundation.org> In-Reply-To: <5111B318.9020204@cn.fujitsu.com> References: <51113CE3.5090000@gmail.com> <20130205192640.GC6481@cmpxchg.org> <20130205141332.04fcceac.akpm@linux-foundation.org> <5111AC7D.9070505@cn.fujitsu.com> <20130205172057.3be4dbd4.akpm@linux-foundation.org> <5111B318.9020204@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Zhang Yanfei Cc: Johannes Weiner , Zhang Yanfei , Linux MM , mgorman@suse.de, minchan@kernel.org, kamezawa.hiroyu@jp.fujitsu.com, m.szyprowski@samsung.com, linux-kernel@vger.kernel.org On Wed, 06 Feb 2013 09:34:16 +0800 Zhang Yanfei wrote: > > > > > > hm, > > > > static unsigned int nr_free_zone_pages(int offset) > > { > > ... > > unsigned int sum = 0; > > ... > > return sum; > > } > > > > How long will it be until these things start exploding from > > sums-of-zones which exceed 16TB? > > > > You mean overflow? Hmm.. it might happens. Change the sum to > unsigned long is ok? The sum, the return value. And in the case of nr_free_buffer_pages(), the signedness of the return value (sheesh). Then review and if necessary fix up all the callsites. That's all a separate exercise. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org