linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: azurIt <azurit@pobox.sk>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	cgroups mailinglist <cgroups@vger.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH for 3.2.34] memcg: do not trigger OOM if PF_NO_MEMCG_OOM is set
Date: Fri, 8 Feb 2013 16:24:02 +0100	[thread overview]
Message-ID: <20130208152402.GD7557@dhcp22.suse.cz> (raw)
In-Reply-To: <20130208145616.FB78CE24@pobox.sk>

On Fri 08-02-13 14:56:16, azurIt wrote:
> >kernel log would be sufficient.
> 
> 
> Full kernel log from kernel with you newest patch:
> http://watchdog.sk/lkml/kern2.log

OK, so the log says that there is a little slaughter on your yard:
$ grep "Memory cgroup out of memory:" kern2.log | wc -l
220

$ grep "Memory cgroup out of memory:" kern2.log | sed 's@.*Kill process \([0-9]*\) .*@\1@' | sort -u | wc -l
220

Which means that the oom killer didn't try to kill any task more than
once which is good because it tells us that the killed task manages to
die before we trigger oom again. So this is definitely not a deadlock.
You are just hitting OOM very often.
$ grep "killed as a result of limit" kern2.log | sed 's@.*\] @@' | sort | uniq -c | sort -k1 -n
      1 Task in /1091/uid killed as a result of limit of /1091
      1 Task in /1223/uid killed as a result of limit of /1223
      1 Task in /1229/uid killed as a result of limit of /1229
      1 Task in /1255/uid killed as a result of limit of /1255
      1 Task in /1424/uid killed as a result of limit of /1424
      1 Task in /1470/uid killed as a result of limit of /1470
      1 Task in /1567/uid killed as a result of limit of /1567
      2 Task in /1080/uid killed as a result of limit of /1080
      3 Task in /1381/uid killed as a result of limit of /1381
      4 Task in /1185/uid killed as a result of limit of /1185
      4 Task in /1289/uid killed as a result of limit of /1289
      4 Task in /1709/uid killed as a result of limit of /1709
      5 Task in /1279/uid killed as a result of limit of /1279
      6 Task in /1020/uid killed as a result of limit of /1020
      6 Task in /1527/uid killed as a result of limit of /1527
      9 Task in /1388/uid killed as a result of limit of /1388
     17 Task in /1281/uid killed as a result of limit of /1281
     22 Task in /1599/uid killed as a result of limit of /1599
     30 Task in /1155/uid killed as a result of limit of /1155
     31 Task in /1258/uid killed as a result of limit of /1258
     71 Task in /1293/uid killed as a result of limit of /1293

So the group 1293 suffers the most. I would check how much memory the
worklod in the group really needs because this level of OOM cannot
possible be healthy.

The log also says that the deadlock prevention implemented by the patch
triggered and some writes really failed due to potential OOM:
$ grep "If this message shows up" kern2.log 
Feb  8 01:17:10 server01 kernel: [  431.033593] __mem_cgroup_try_charge: task:apache2 pid:6733 got ENOMEM without OOM for memcg:ffff8803807d5600. If this message shows up very often for the same task then there is a risk that the process is not able to make any progress because of the current limit. Try to enlarge the hard limit.
Feb  8 01:22:52 server01 kernel: [  773.556782] __mem_cgroup_try_charge: task:apache2 pid:12092 got ENOMEM without OOM for memcg:ffff8803807d5600. If this message shows up very often for the same task then there is a risk that the process is not able to make any progress because of the current limit. Try to enlarge the hard limit.
Feb  8 01:22:52 server01 kernel: [  773.567916] __mem_cgroup_try_charge: task:apache2 pid:12093 got ENOMEM without OOM for memcg:ffff8803807d5600. If this message shows up very often for the same task then there is a risk that the process is not able to make any progress because of the current limit. Try to enlarge the hard limit.
Feb  8 01:29:00 server01 kernel: [ 1141.355693] __mem_cgroup_try_charge: task:apache2 pid:17734 got ENOMEM without OOM for memcg:ffff88036e956e00. If this message shows up very often for the same task then there is a risk that the process is not able to make any progress because of the current limit. Try to enlarge the hard limit.
Feb  8 03:30:39 server01 kernel: [ 8440.346811] __mem_cgroup_try_charge: task:apache2 pid:8687 got ENOMEM without OOM for memcg:ffff8803654d6e00. If this message shows up very often for the same task then there is a risk that the process is not able to make any progress because of the current limit. Try to enlarge the hard limit.

This doesn't look very unhealthy. I have expected that write would fail
more often but it seems that the biggest memory pressure comes from
mmaps and page faults which have no way other than OOM.

So my suggestion would be to reconsider limits for groups to provide
more realistical environment.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2013-02-08 15:24 UTC|newest]

Thread overview: 171+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20121121200207.01068046@pobox.sk>
2012-11-22  0:26 ` memory-cgroup bug Kamezawa Hiroyuki
2012-11-22  9:36   ` azurIt
2012-11-22 21:45     ` Michal Hocko
2012-11-22 15:24 ` Michal Hocko
2012-11-22 18:05   ` azurIt
2012-11-22 21:42     ` Michal Hocko
2012-11-22 22:34       ` azurIt
2012-11-23  7:40         ` Michal Hocko
2012-11-23  9:21           ` azurIt
2012-11-23  9:28             ` Michal Hocko
2012-11-23  9:44               ` azurIt
2012-11-23 10:10                 ` Michal Hocko
2012-11-23  9:34             ` Glauber Costa
2012-11-23 10:04             ` Michal Hocko
2012-11-23 14:59               ` azurIt
2012-11-25 10:17                 ` Michal Hocko
2012-11-25 12:39                   ` azurIt
2012-11-25 13:02                     ` Michal Hocko
2012-11-25 13:27                       ` azurIt
2012-11-25 13:44                         ` Michal Hocko
2012-11-25  0:10               ` azurIt
2012-11-25 12:05                 ` Michal Hocko
2012-11-25 12:36                   ` azurIt
2012-11-25 13:55                   ` Michal Hocko
2012-11-26  0:38                     ` azurIt
2012-11-26  7:57                       ` Michal Hocko
2012-11-26 13:18                       ` [PATCH -mm] memcg: do not trigger OOM from add_to_page_cache_locked Michal Hocko
2012-11-26 13:21                         ` [PATCH for 3.2.34] " Michal Hocko
2012-11-26 21:28                           ` azurIt
2012-11-30  1:45                           ` azurIt
2012-11-30  2:29                           ` azurIt
2012-11-30 12:45                             ` Michal Hocko
2012-11-30 12:53                               ` azurIt
2012-11-30 13:44                               ` azurIt
2012-11-30 14:44                                 ` Michal Hocko
2012-11-30 15:03                                   ` Michal Hocko
2012-11-30 15:37                                     ` Michal Hocko
2012-11-30 15:08                                   ` azurIt
2012-11-30 15:39                                     ` Michal Hocko
2012-11-30 15:59                                       ` azurIt
2012-11-30 16:19                                         ` Michal Hocko
2012-11-30 16:26                                           ` azurIt
2012-11-30 16:53                                             ` Michal Hocko
2012-11-30 20:43                                               ` azurIt
2012-12-03 15:16                                           ` Michal Hocko
2012-12-05  1:36                                             ` azurIt
2012-12-05 14:17                                               ` Michal Hocko
2012-12-06  0:29                                                 ` azurIt
2012-12-06  9:54                                                   ` Michal Hocko
2012-12-06 10:12                                                     ` azurIt
2012-12-06 17:06                                                       ` Michal Hocko
2012-12-10  1:20                                                     ` azurIt
2012-12-10  9:43                                                       ` Michal Hocko
2012-12-10 10:18                                                         ` azurIt
2012-12-10 15:52                                                           ` Michal Hocko
2012-12-10 17:18                                                             ` azurIt
2012-12-17  1:34                                                             ` azurIt
2012-12-17 16:32                                                               ` Michal Hocko
2012-12-17 18:23                                                                 ` azurIt
2012-12-17 19:55                                                                   ` Michal Hocko
2012-12-18 14:22                                                                     ` azurIt
2012-12-18 15:20                                                                       ` Michal Hocko
2012-12-24 13:25                                                                         ` azurIt
2012-12-28 16:22                                                                           ` Michal Hocko
2012-12-30  1:09                                                                             ` azurIt
2012-12-30 11:08                                                                               ` Michal Hocko
2013-01-25 15:07                                                                                 ` azurIt
2013-01-25 16:31                                                                                   ` Michal Hocko
2013-02-05 13:49                                                                                     ` Michal Hocko
2013-02-05 14:49                                                                                       ` azurIt
2013-02-05 16:09                                                                                         ` Michal Hocko
2013-02-05 16:46                                                                                           ` azurIt
2013-02-05 16:48                                                                                           ` Greg Thelen
2013-02-05 17:46                                                                                             ` Michal Hocko
2013-02-05 18:09                                                                                               ` Greg Thelen
2013-02-05 18:59                                                                                                 ` Michal Hocko
2013-02-08  4:27                                                                                                   ` Greg Thelen
2013-02-08 16:29                                                                                                     ` Michal Hocko
2013-02-08 16:40                                                                                                       ` Michal Hocko
2013-02-06  1:17                                                                                           ` azurIt
2013-02-06 14:01                                                                                             ` Michal Hocko
2013-02-06 14:22                                                                                               ` Michal Hocko
2013-02-06 16:00                                                                                                 ` [PATCH for 3.2.34] memcg: do not trigger OOM if PF_NO_MEMCG_OOM is set Michal Hocko
2013-02-08  5:03                                                                                                   ` azurIt
2013-02-08  9:44                                                                                                     ` Michal Hocko
2013-02-08 11:02                                                                                                       ` azurIt
2013-02-08 12:38                                                                                                         ` Michal Hocko
2013-02-08 13:56                                                                                                           ` azurIt
2013-02-08 14:47                                                                                                             ` Michal Hocko
2013-02-08 15:24                                                                                                             ` Michal Hocko [this message]
2013-02-08 15:58                                                                                                               ` azurIt
2013-02-08 17:10                                                                                                                 ` Michal Hocko
2013-02-08 21:02                                                                                                                   ` azurIt
2013-02-10 15:03                                                                                                                     ` Michal Hocko
2013-02-10 16:46                                                                                                                       ` azurIt
2013-02-11 11:22                                                                                                                         ` Michal Hocko
2013-02-22  8:23                                                                                                                           ` azurIt
2013-02-22 12:52                                                                                                                             ` Michal Hocko
2013-02-22 12:54                                                                                                                               ` azurIt
2013-02-22 13:00                                                                                                                                 ` Michal Hocko
2013-06-06 16:04                                                                                                                             ` Michal Hocko
2013-06-06 16:16                                                                                                                               ` azurIt
2013-06-07 13:11                                                                                                                                 ` [PATCH for 3.2] memcg: do not trap chargers with full callstack on OOM Michal Hocko
2013-06-17 10:21                                                                                                                                   ` azurIt
2013-06-19 13:26                                                                                                                                     ` Michal Hocko
2013-06-22 20:09                                                                                                                                       ` azurIt
2013-06-24 20:13                                                                                                                                         ` Johannes Weiner
2013-06-28 10:06                                                                                                                                           ` azurIt
2013-07-05 18:17                                                                                                                                             ` Johannes Weiner
2013-07-05 19:02                                                                                                                                               ` azurIt
2013-07-05 19:18                                                                                                                                                 ` Johannes Weiner
2013-07-07 23:42                                                                                                                                                   ` azurIt
2013-07-09 13:10                                                                                                                                                     ` Michal Hocko
2013-07-09 13:19                                                                                                                                                       ` azurIt
2013-07-09 13:54                                                                                                                                                         ` Michal Hocko
2013-07-10 16:25                                                                                                                                                           ` azurIt
2013-07-11  7:25                                                                                                                                                             ` Michal Hocko
2013-07-13 23:26                                                                                                                                                               ` azurIt
2013-07-13 23:51                                                                                                                                                                 ` azurIt
2013-07-15 15:41                                                                                                                                                                   ` Michal Hocko
2013-07-15 16:00                                                                                                                                                                     ` Michal Hocko
2013-07-16 15:35                                                                                                                                                                       ` Johannes Weiner
2013-07-16 16:09                                                                                                                                                                         ` Michal Hocko
2013-07-16 16:48                                                                                                                                                                           ` Johannes Weiner
2013-07-19  4:21                                                                                                                                                                             ` Johannes Weiner
2013-07-19  4:22                                                                                                                                                                               ` [patch 1/5] mm: invoke oom-killer from remaining unconverted page fault handlers Johannes Weiner
2013-07-19  4:24                                                                                                                                                                               ` [patch 2/5] mm: pass userspace fault flag to generic fault handler Johannes Weiner
2013-07-19  4:25                                                                                                                                                                               ` [patch 3/5] x86: finish fault error path with fatal signal Johannes Weiner
2013-07-24 20:32                                                                                                                                                                                 ` Johannes Weiner
2013-07-25 20:29                                                                                                                                                                                   ` KOSAKI Motohiro
2013-07-25 21:50                                                                                                                                                                                     ` Johannes Weiner
2013-07-19  4:25                                                                                                                                                                               ` [patch 4/5] memcg: do not trap chargers with full callstack on OOM Johannes Weiner
2013-07-19  4:26                                                                                                                                                                               ` [patch 5/5] mm: memcontrol: sanity check memcg OOM context unwind Johannes Weiner
2013-07-19  8:23                                                                                                                                                                               ` [PATCH for 3.2] memcg: do not trap chargers with full callstack on OOM azurIt
2013-07-14 17:07                                                                                                                                                   ` azurIt
2013-07-09 13:00                                                                                                                                           ` Michal Hocko
2013-07-09 13:08                                                                                                                                             ` Michal Hocko
2013-07-09 13:10                                                                                                                                               ` Michal Hocko
2013-06-24 16:48                                                                                                                                       ` azurIt
2013-02-22 12:00                                                                                                                           ` [PATCH for 3.2.34] memcg: do not trigger OOM if PF_NO_MEMCG_OOM is set azurIt
2013-02-07 11:01                                                                                               ` [PATCH for 3.2.34] memcg: do not trigger OOM from add_to_page_cache_locked Kamezawa Hiroyuki
2013-02-07 12:31                                                                                                 ` Michal Hocko
2013-02-08  4:16                                                                                                   ` Kamezawa Hiroyuki
2013-02-08  1:40                                                                                                 ` Kamezawa Hiroyuki
2013-02-08 16:01                                                                                                   ` Michal Hocko
2013-02-05 16:31                                                                                         ` Michal Hocko
2012-12-24 13:38                                                                         ` azurIt
2012-12-28 16:35                                                                           ` Michal Hocko
2012-11-26 17:46                         ` [PATCH -mm] " Johannes Weiner
2012-11-26 18:04                           ` Michal Hocko
2012-11-26 18:24                             ` Johannes Weiner
2012-11-26 19:03                               ` Michal Hocko
2012-11-26 19:29                                 ` Johannes Weiner
2012-11-26 20:08                                   ` Michal Hocko
2012-11-26 20:19                                     ` Johannes Weiner
2012-11-26 20:46                                       ` azurIt
2012-11-26 20:53                                         ` Johannes Weiner
2012-11-26 22:06                                       ` Michal Hocko
2012-11-27  0:05                         ` Kamezawa Hiroyuki
2012-11-27  9:54                           ` Michal Hocko
2012-11-27 19:48                           ` Johannes Weiner
2012-11-27 20:54                             ` [PATCH -v2 " Michal Hocko
2012-11-27 20:59                               ` Michal Hocko
2012-11-28 15:26                                 ` Johannes Weiner
2012-11-28 16:04                                   ` Michal Hocko
2012-11-28 16:37                                     ` Johannes Weiner
2012-11-28 16:46                                       ` Michal Hocko
2012-11-28 16:48                                         ` Michal Hocko
2012-11-28 18:44                                           ` Johannes Weiner
2012-11-28 20:20                                           ` Hugh Dickins
2012-11-29 14:05                                             ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130208152402.GD7557@dhcp22.suse.cz \
    --to=mhocko@suse.cz \
    --cc=azurit@pobox.sk \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).