From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx160.postini.com [74.125.245.160]) by kanga.kvack.org (Postfix) with SMTP id EEF696B0007 for ; Tue, 12 Feb 2013 19:22:24 -0500 (EST) Date: Tue, 12 Feb 2013 16:22:22 -0800 From: Andrew Morton Subject: Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting Message-Id: <20130212162222.e4103ddb.akpm@linux-foundation.org> In-Reply-To: References: <51074786.5030007@huawei.com> <1359995565.7515.178.camel@mfleming-mobl1.ger.corp.intel.com> <51131248.3080203@huawei.com> <5113450C.1080109@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tony Luck Cc: Xishi Qiu , Matt Fleming , fenghua.yu@intel.com, Liujiang , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, Hanjun Guo , WuJianguo On Tue, 12 Feb 2013 16:11:33 -0800 Tony Luck wrote: > Building linux-next today (tag next-20130212) I get the following errors when > building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig, > sim_defconfig} > > arch/ia64/mm/init.c: In function 'free_initrd_mem': > arch/ia64/mm/init.c:215: error: 'max_addr' undeclared (first use in > this function) > arch/ia64/mm/init.c:215: error: (Each undeclared identifier is > reported only once > arch/ia64/mm/init.c:215: error: for each function it appears in.) > arch/ia64/mm/init.c:216: error: implicit declaration of function > 'GRANULEROUNDDOWN' > `max_addr' is an awesomely bad name for a global identifier, btw. And this: -static u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL; +u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL; needlessly exported `mem_limit' and `min_addr' as well. These too are very poor global identifiers. Also, Matt suggested an alternative implementation which afaik hasn't been responded to. I think I'll just drop the patch. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org