From: Minchan Kim <minchan@kernel.org>
To: Anton Vorontsov <anton@enomsg.org>
Cc: Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org, David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>, Mel Gorman <mgorman@suse.de>,
Glauber Costa <glommer@parallels.com>,
Michal Hocko <mhocko@suse.cz>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Thelen <gthelen@google.com>,
Leonid Moiseichuk <leonid.moiseichuk@nokia.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
John Stultz <john.stultz@linaro.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com
Subject: Re: [PATCH v2] memcg: Add memory.pressure_level events
Date: Fri, 22 Feb 2013 08:56:08 +0900 [thread overview]
Message-ID: <20130221235608.GH16950@blaptop> (raw)
In-Reply-To: <20130221230425.GA22792@lizard.fhda.edu>
Hi Anton,
On Thu, Feb 21, 2013 at 03:04:26PM -0800, Anton Vorontsov wrote:
> On Tue, Feb 19, 2013 at 04:21:28PM -0800, Tejun Heo wrote:
> > On Tue, Feb 19, 2013 at 4:17 PM, Minchan Kim <minchan@kernel.org> wrote:
> > > Should we really enable memcg for just pressure notificaion in embedded side?
> > > I didn't check the size(cgroup + memcg) and performance penalty but I don't want
> > > to add unnecessary overhead if it is possible.
> > > Do you have a plan to support it via global knob(ie, /proc/mempressure), NOT memcg?
> >
> > That should be handled by mempressure at the root cgroup. If that adds
> > significant amount of overhead code or memory-wise, we just need to
> > fix root cgroup handling in memcg. No reason to further complicate the
> > interface which already is pretty complex.
>
> For what it worth, I agree here. Even if we decide to make another
> interface to vmpressure (which, say, would not require memcg), then it is
> better to keep the API the same: eventfd + control file. That way,
> API/ABI-wise there will be no differnce between memcg and non-memcg
> kernels, which is cool.
I tend to agree Tejun's opinion POV maintain and I don't have a number
of memcg static/dynamic effect for embedded side so I don't want to argue now.
AFAIRC, Mel reported last year that memcg had rather no small runtime effect
and some memcg guys are trying to solve it. The memcg guy among Cced guys of
this thread could answer that more clearly.
I don't care whatever API looks like. Of course, keeping the API the same is
always good if we decide to need it. The my point is that you have a plan
to support? Why I have a question is that you said your goal is to replace
lowmemory killer but android don't have enabled CONFIG_MEMCG as you know well
so they should enable it for using just notifier? or they need another hack to
connect notifier to global thing?
What's the plan?
>
> Thanks,
> Anton
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-21 23:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 4:40 [PATCH v2] memcg: Add memory.pressure_level events Anton Vorontsov
2013-02-20 0:17 ` Minchan Kim
2013-02-20 0:21 ` Tejun Heo
2013-02-21 23:04 ` Anton Vorontsov
2013-02-21 23:56 ` Minchan Kim [this message]
2013-02-22 6:55 ` Anton Vorontsov
2013-02-22 7:26 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221235608.GH16950@blaptop \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anton@enomsg.org \
--cc=b.zolnierkie@samsung.com \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=gthelen@google.com \
--cc=john.stultz@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kernel-team@android.com \
--cc=kirill@shutemov.name \
--cc=kosaki.motohiro@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=leonid.moiseichuk@nokia.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=patches@linaro.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).