From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Glauber Costa <glommer@parallels.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH v2] slub: correctly bootstrap boot caches
Date: Mon, 25 Feb 2013 14:16:15 +0900 [thread overview]
Message-ID: <20130225051615.GC12158@lge.com> (raw)
In-Reply-To: <0000013d09a01f03-376fad0e-700d-4a04-8da2-89e6b3a22408-000000@email.amazonses.com>
Hello, Christoph.
On Sun, Feb 24, 2013 at 12:35:22AM +0000, Christoph Lameter wrote:
> On Sat, 23 Feb 2013, JoonSoo Kim wrote:
>
> > With flushing, deactivate_slab() occur and it has some overhead to
> > deactivate objects.
> > If my patch properly fix this situation, it is better to use mine
> > which has no overhead.
>
> Well this occurs during boot and its not that performance critical.
Hmm...
Yes, this is not performance critical place, but why do we use
a sub-optimal solution?
And flushing is abstration for complicated logic, so I think that
my raw implemntation is better for understanding.
But, I have no objection to merge Glauber's one
if you think that is better.
Thanks.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-25 5:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 16:20 [PATCH v2] slub: correctly bootstrap boot caches Glauber Costa
2013-02-22 16:34 ` Christoph Lameter
[not found] ` <alpine.DEB.2.02.1302221034380.7600@gentwo.org>
2013-02-22 17:00 ` Christoph Lameter
[not found] ` <alpine.DEB.2.02.1302221057430.7600@gentwo.org>
2013-02-22 17:01 ` Christoph Lameter
2013-02-22 17:08 ` Glauber Costa
2013-02-22 17:23 ` Christoph Lameter
2013-02-22 23:20 ` JoonSoo Kim
2013-02-24 0:35 ` Christoph Lameter
2013-02-25 5:16 ` Joonsoo Kim [this message]
2013-02-27 7:47 ` Pekka Enberg
2013-02-27 13:46 ` Glauber Costa
2013-02-27 16:39 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225051615.GC12158@lge.com \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).