linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] slub: correctly bootstrap boot caches
@ 2013-02-22 16:20 Glauber Costa
  2013-02-22 16:34 ` Christoph Lameter
       [not found] ` <alpine.DEB.2.02.1302221034380.7600@gentwo.org>
  0 siblings, 2 replies; 12+ messages in thread
From: Glauber Costa @ 2013-02-22 16:20 UTC (permalink / raw)
  To: linux-mm
  Cc: linux-kernel, cgroups, Glauber Costa, Christoph Lameter,
	Andrew Morton, Tejun Heo, Pekka Enberg

After we create a boot cache, we may allocate from it until it is bootstraped.
This will move the page from the partial list to the cpu slab list. If this
happens, the loop:

	list_for_each_entry(p, &n->partial, lru)

that we use to scan for all partial pages will yield nothing, and the pages
will keep pointing to the boot cpu cache, which is of course, invalid. To do
that, we should flush the cache to make sure that the cpu slab is back to the
partial list.

Signed-off-by: Glauber Costa <glommer@parallels.com>
Reported-by:  Steffen Michalke <StMichalke@web.de>
Tested-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>

 mm/slub.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)
---
 mm/slub.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/mm/slub.c b/mm/slub.c
index ba2ca53..31a494c 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3617,6 +3617,12 @@ static struct kmem_cache * __init bootstrap(struct kmem_cache *static_cache)
 
 	memcpy(s, static_cache, kmem_cache->object_size);
 
+	/*
+	 * This runs very early, and only the boot processor is supposed to be
+	 * up.  Even if it weren't true, IRQs are not up so we couldn't fire
+	 * IPIs around.
+	 */
+	__flush_cpu_slab(s, smp_processor_id());
 	for_each_node_state(node, N_NORMAL_MEMORY) {
 		struct kmem_cache_node *n = get_node(s, node);
 		struct page *p;
-- 
1.8.1.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-02-27 16:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-22 16:20 [PATCH v2] slub: correctly bootstrap boot caches Glauber Costa
2013-02-22 16:34 ` Christoph Lameter
     [not found] ` <alpine.DEB.2.02.1302221034380.7600@gentwo.org>
2013-02-22 17:00   ` Christoph Lameter
     [not found]   ` <alpine.DEB.2.02.1302221057430.7600@gentwo.org>
2013-02-22 17:01     ` Christoph Lameter
2013-02-22 17:08       ` Glauber Costa
2013-02-22 17:23         ` Christoph Lameter
2013-02-22 23:20           ` JoonSoo Kim
2013-02-24  0:35             ` Christoph Lameter
2013-02-25  5:16               ` Joonsoo Kim
2013-02-27  7:47           ` Pekka Enberg
2013-02-27 13:46             ` Glauber Costa
2013-02-27 16:39               ` Christoph Lameter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).