linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Shewmaker <agshew@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 2/2] mm: tuning hardcoded reserved memory
Date: Wed, 27 Feb 2013 21:19:50 -0500	[thread overview]
Message-ID: <20130228021950.GA3829@localhost.localdomain> (raw)
In-Reply-To: <20130228141441.7dbd19be.akpm@linux-foundation.org>

On Thu, Feb 28, 2013 at 02:14:41PM -0800, Andrew Morton wrote:
> On Wed, 27 Feb 2013 16:09:25 -0500
> Andrew Shewmaker <agshew@gmail.com> wrote:
> 
> > Add a rootuser_reserve_pages knob to allow admins of large memory 
> > systems running with overcommit disabled to change the hardcoded 
> > memory reserve to something other than 3%.
> > 
> > Signed-off-by: Andrew Shewmaker <agshew@gmail.com>
> > 
> > ---
> > 
> > Patch based off of mmotm git tree as of February 27th.
> > 
> > I set rootuser_reserve pages to be a default of 1000, and I suppose 
> > I should have initialzed similarly to the way min_free_kbytes is, 
> > scaling it with the size of the box. However, I wanted to get a 
> > simple version of this patch out for feedback to see if it has any 
> > chance of acceptance or if I need to take an entirely different 
> > approach.
> > 
> > Any feedback will be appreciated!
> 
> Seems reasonable.
> 
> Yes, we should scale the initial value according to the machine size in
> some fashion.
> 
> btw, both these patches had the same title.  Please avoid this.
> Documentation/SubmittingPatches section 15 has all the details.

Sorry about that. I'll resend correctly formatted patche submissions 
with a scaled initial value for rootuser_reserve_pages.

Thanks for the feedback!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-02-28 23:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 21:09 [RFC PATCH v2 2/2] mm: tuning hardcoded reserved memory Andrew Shewmaker
2013-02-28 22:14 ` Andrew Morton
2013-02-28  2:19   ` Andrew Shewmaker [this message]
2013-03-01  0:16 ` Simon Jeons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130228021950.GA3829@localhost.localdomain \
    --to=agshew@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).