* change of behavior for madvise in 3.9-rc1
[not found] <1543700056.10481632.1362628775559.JavaMail.root@redhat.com>
@ 2013-03-07 4:05 ` CAI Qian
2013-03-07 4:39 ` Shaohua Li
0 siblings, 1 reply; 4+ messages in thread
From: CAI Qian @ 2013-03-07 4:05 UTC (permalink / raw)
To: Shaohua Li
Cc: linux-mm, linux-kernel, Hugh Dickins, Rik van Riel, Sasha Levin,
Andrew Morton, Linus Torvalds
Bisecting indicated that this commit,
1998cc048901109a29924380b8e91bc049b32951
mm: make madvise(MADV_WILLNEED) support swap file prefetch
Caused an LTP test failure,
http://goo.gl/1FVPy
madvise02 1 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
madvise02 2 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
madvise02 3 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
madvise02 4 TPASS : failed as expected: TEST_ERRNO=ENOMEM(12): Cannot allocate memory
madvise02 5 TFAIL : madvise succeeded unexpectedly
While it passed without the above commit
madvise02 1 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
madvise02 2 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
madvise02 3 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
madvise02 4 TPASS : failed as expected: TEST_ERRNO=ENOMEM(12): Cannot allocate memory
madvise02 5 TPASS : failed as expected: TEST_ERRNO=EBADF(9): Bad file descriptor
CAI Qian
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: change of behavior for madvise in 3.9-rc1
2013-03-07 4:05 ` change of behavior for madvise in 3.9-rc1 CAI Qian
@ 2013-03-07 4:39 ` Shaohua Li
2013-03-07 18:49 ` Hugh Dickins
0 siblings, 1 reply; 4+ messages in thread
From: Shaohua Li @ 2013-03-07 4:39 UTC (permalink / raw)
To: CAI Qian
Cc: linux-mm, linux-kernel, Hugh Dickins, Rik van Riel, Sasha Levin,
Andrew Morton, Linus Torvalds
On Wed, Mar 06, 2013 at 11:05:04PM -0500, CAI Qian wrote:
> Bisecting indicated that this commit,
> 1998cc048901109a29924380b8e91bc049b32951
> mm: make madvise(MADV_WILLNEED) support swap file prefetch
>
> Caused an LTP test failure,
> http://goo.gl/1FVPy
>
> madvise02 1 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> madvise02 2 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> madvise02 3 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> madvise02 4 TPASS : failed as expected: TEST_ERRNO=ENOMEM(12): Cannot allocate memory
> madvise02 5 TFAIL : madvise succeeded unexpectedly
>
> While it passed without the above commit
> madvise02 1 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> madvise02 2 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> madvise02 3 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> madvise02 4 TPASS : failed as expected: TEST_ERRNO=ENOMEM(12): Cannot allocate memory
> madvise02 5 TPASS : failed as expected: TEST_ERRNO=EBADF(9): Bad file descriptor
I thought this is expected behavior. madvise(MADV_WILLNEED) to anonymous memory
doesn't return -EBADF now, as now we support swap prefretch.
Thanks,
Shaohua
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: change of behavior for madvise in 3.9-rc1
2013-03-07 4:39 ` Shaohua Li
@ 2013-03-07 18:49 ` Hugh Dickins
2013-03-08 2:05 ` CAI Qian
0 siblings, 1 reply; 4+ messages in thread
From: Hugh Dickins @ 2013-03-07 18:49 UTC (permalink / raw)
To: Shaohua Li
Cc: CAI Qian, linux-mm, linux-kernel, Rik van Riel, Sasha Levin,
Andrew Morton, Linus Torvalds
On Thu, 7 Mar 2013, Shaohua Li wrote:
> On Wed, Mar 06, 2013 at 11:05:04PM -0500, CAI Qian wrote:
> > Bisecting indicated that this commit,
> > 1998cc048901109a29924380b8e91bc049b32951
> > mm: make madvise(MADV_WILLNEED) support swap file prefetch
> >
> > Caused an LTP test failure,
> > http://goo.gl/1FVPy
> >
> > madvise02 1 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> > madvise02 2 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> > madvise02 3 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> > madvise02 4 TPASS : failed as expected: TEST_ERRNO=ENOMEM(12): Cannot allocate memory
> > madvise02 5 TFAIL : madvise succeeded unexpectedly
> >
> > While it passed without the above commit
> > madvise02 1 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> > madvise02 2 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> > madvise02 3 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument
> > madvise02 4 TPASS : failed as expected: TEST_ERRNO=ENOMEM(12): Cannot allocate memory
> > madvise02 5 TPASS : failed as expected: TEST_ERRNO=EBADF(9): Bad file descriptor
>
> I thought this is expected behavior. madvise(MADV_WILLNEED) to anonymous memory
> doesn't return -EBADF now, as now we support swap prefretch.
I agree with Shaohua: although the kernel strives for back-compatibility
with userspace, I don't think that goes so far as to tell an arbitrary LTP
test that it has failed, once the kernel has been enhanced to support new
functionality. We could never add or extend system calls if that were so.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: change of behavior for madvise in 3.9-rc1
2013-03-07 18:49 ` Hugh Dickins
@ 2013-03-08 2:05 ` CAI Qian
0 siblings, 0 replies; 4+ messages in thread
From: CAI Qian @ 2013-03-08 2:05 UTC (permalink / raw)
To: Hugh Dickins
Cc: linux-mm, linux-kernel, Rik van Riel, Sasha Levin, Andrew Morton,
Linus Torvalds, Shaohua Li
----- Original Message -----
> From: "Hugh Dickins" <hughd@google.com>
> To: "Shaohua Li" <shli@kernel.org>
> Cc: "CAI Qian" <caiqian@redhat.com>, "linux-mm" <linux-mm@kvack.org>, "linux-kernel" <linux-kernel@vger.kernel.org>,
> "Rik van Riel" <riel@redhat.com>, "Sasha Levin" <sasha.levin@oracle.com>, "Andrew Morton"
> <akpm@linux-foundation.org>, "Linus Torvalds" <torvalds@linux-foundation.org>
> Sent: Friday, March 8, 2013 2:49:48 AM
> Subject: Re: change of behavior for madvise in 3.9-rc1
>
> On Thu, 7 Mar 2013, Shaohua Li wrote:
> > On Wed, Mar 06, 2013 at 11:05:04PM -0500, CAI Qian wrote:
> > > Bisecting indicated that this commit,
> > > 1998cc048901109a29924380b8e91bc049b32951
> > > mm: make madvise(MADV_WILLNEED) support swap file prefetch
> > >
> > > Caused an LTP test failure,
> > > http://goo.gl/1FVPy
> > >
> > > madvise02 1 TPASS : failed as expected:
> > > TEST_ERRNO=EINVAL(22): Invalid argument
> > > madvise02 2 TPASS : failed as expected:
> > > TEST_ERRNO=EINVAL(22): Invalid argument
> > > madvise02 3 TPASS : failed as expected:
> > > TEST_ERRNO=EINVAL(22): Invalid argument
> > > madvise02 4 TPASS : failed as expected:
> > > TEST_ERRNO=ENOMEM(12): Cannot allocate memory
> > > madvise02 5 TFAIL : madvise succeeded unexpectedly
> > >
> > > While it passed without the above commit
> > > madvise02 1 TPASS : failed as expected:
> > > TEST_ERRNO=EINVAL(22): Invalid argument
> > > madvise02 2 TPASS : failed as expected:
> > > TEST_ERRNO=EINVAL(22): Invalid argument
> > > madvise02 3 TPASS : failed as expected:
> > > TEST_ERRNO=EINVAL(22): Invalid argument
> > > madvise02 4 TPASS : failed as expected:
> > > TEST_ERRNO=ENOMEM(12): Cannot allocate memory
> > > madvise02 5 TPASS : failed as expected:
> > > TEST_ERRNO=EBADF(9): Bad file descriptor
> >
> > I thought this is expected behavior. madvise(MADV_WILLNEED) to
> > anonymous memory
> > doesn't return -EBADF now, as now we support swap prefretch.
>
> I agree with Shaohua: although the kernel strives for
> back-compatibility
> with userspace, I don't think that goes so far as to tell an
> arbitrary LTP
> test that it has failed, once the kernel has been enhanced to support
> new
> functionality. We could never add or extend system calls if that
> were so.
Thanks for looking this. We will try to fix the LTP test instead.
>
> Hugh
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-08 2:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1543700056.10481632.1362628775559.JavaMail.root@redhat.com>
2013-03-07 4:05 ` change of behavior for madvise in 3.9-rc1 CAI Qian
2013-03-07 4:39 ` Shaohua Li
2013-03-07 18:49 ` Hugh Dickins
2013-03-08 2:05 ` CAI Qian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).