From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx107.postini.com [74.125.245.107]) by kanga.kvack.org (Postfix) with SMTP id AED296B0006 for ; Tue, 12 Mar 2013 17:42:17 -0400 (EDT) Date: Tue, 12 Mar 2013 14:42:15 -0700 From: Andrew Morton Subject: Re: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system Message-Id: <20130312144215.1a92be86464bf82f81e3055e@linux-foundation.org> In-Reply-To: <1362902470-25787-9-git-send-email-jiang.liu@huawei.com> References: <1362902470-25787-1-git-send-email-jiang.liu@huawei.com> <1362902470-25787-9-git-send-email-jiang.liu@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: David Rientjes , Jiang Liu , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "David S. Miller" , Sam Ravnborg , sparclinux@vger.kernel.org On Sun, 10 Mar 2013 16:01:08 +0800 Jiang Liu wrote: > Use helper function free_highmem_page() to free highmem pages into > the buddy system. > > ... > > --- a/arch/sparc/mm/init_32.c > +++ b/arch/sparc/mm/init_32.c > @@ -282,14 +282,8 @@ static void map_high_region(unsigned long start_pfn, unsigned long end_pfn) > printk("mapping high region %08lx - %08lx\n", start_pfn, end_pfn); > #endif > > - for (tmp = start_pfn; tmp < end_pfn; tmp++) { > - struct page *page = pfn_to_page(tmp); > - > - ClearPageReserved(page); > - init_page_count(page); > - __free_page(page); > - totalhigh_pages++; > - } > + for (tmp = start_pfn; tmp < end_pfn; tmp++) > + free_higmem_page(pfn_to_page(tmp)); > } This code isn't inside #ifdef CONFIG_HIGHMEM, but afaict that's OK because CONFIG_HIGHMEM=n isn't possible on sparc32. This patch and one other mistyped "free_highmem_page". I got lazy and edited those patches in-place. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org