From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id 3F6DD6B003C for ; Wed, 13 Mar 2013 02:34:54 -0400 (EDT) Date: Wed, 13 Mar 2013 07:34:52 +0100 From: Sam Ravnborg Subject: Re: [PATCH v2, part2 08/10] mm/SPARC: use free_highmem_page() to free highmem pages into buddy system Message-ID: <20130313063452.GA19698@merkur.ravnborg.org> References: <1362902470-25787-1-git-send-email-jiang.liu@huawei.com> <1362902470-25787-9-git-send-email-jiang.liu@huawei.com> <20130312144215.1a92be86464bf82f81e3055e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130312144215.1a92be86464bf82f81e3055e@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Jiang Liu , David Rientjes , Jiang Liu , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org On Tue, Mar 12, 2013 at 02:42:15PM -0700, Andrew Morton wrote: > On Sun, 10 Mar 2013 16:01:08 +0800 Jiang Liu wrote: > > > Use helper function free_highmem_page() to free highmem pages into > > the buddy system. > > > > ... > > > > --- a/arch/sparc/mm/init_32.c > > +++ b/arch/sparc/mm/init_32.c > > @@ -282,14 +282,8 @@ static void map_high_region(unsigned long start_pfn, unsigned long end_pfn) > > printk("mapping high region %08lx - %08lx\n", start_pfn, end_pfn); > > #endif > > > > - for (tmp = start_pfn; tmp < end_pfn; tmp++) { > > - struct page *page = pfn_to_page(tmp); > > - > > - ClearPageReserved(page); > > - init_page_count(page); > > - __free_page(page); > > - totalhigh_pages++; > > - } > > + for (tmp = start_pfn; tmp < end_pfn; tmp++) > > + free_higmem_page(pfn_to_page(tmp)); > > } > > This code isn't inside #ifdef CONFIG_HIGHMEM, but afaict that's OK > because CONFIG_HIGHMEM=n isn't possible on sparc32. Correct - from arch/sparc/Kconfig config HIGHMEM bool default y if SPARC32 > This patch and one other mistyped "free_highmem_page". I got lazy and > edited those patches in-place. Good spot! You can add my: Acked-by: Sam Ravnborg Sam -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org