From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
Hillf Danton <dhillf@gmail.com>, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions
Date: Thu, 14 Mar 2013 15:11:09 +0100 [thread overview]
Message-ID: <20130314151109.5b6927ce@thinkpad> (raw)
In-Reply-To: <20130314131404.GH11631@dhcp22.suse.cz>
On Thu, 14 Mar 2013 14:14:04 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> On Tue 12-03-13 19:48:26, Gerald Schaefer wrote:
> > Commit abf09bed3c "s390/mm: implement software dirty bits" introduced
> > another difference in the pte layout vs. the pmd layout on s390,
> > thoroughly breaking the s390 support for hugetlbfs. This requires
> > replacing some more pte_xxx functions in mm/hugetlbfs.c with a
> > huge_pte_xxx version.
> >
> > This patch introduces those huge_pte_xxx functions and their
> > implementation on all architectures supporting hugetlbfs. This change
> > will be a no-op for all architectures other than s390.
> >
> > Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
> > ---
> > arch/ia64/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> > arch/mips/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> > arch/powerpc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> > arch/s390/include/asm/hugetlb.h | 56 +++++++++++++++++++++++++++++++++++++-
> > arch/s390/include/asm/pgtable.h | 20 --------------
> > arch/s390/mm/hugetlbpage.c | 2 +-
> > arch/sh/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> > arch/sparc/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> > arch/tile/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> > arch/x86/include/asm/hugetlb.h | 36 ++++++++++++++++++++++++
> > mm/hugetlb.c | 23 ++++++++--------
> > 11 files changed, 320 insertions(+), 33 deletions(-)
>
> Ouch, this adds a lot of code that is almost same for all archs except
> for some. Can we just make one common definition and define only those
> that differ, please?
> [...]
Ok, seems like I misinterpreted the ugliness of HAVE_ARCH_xxx vs. code
duplication. Paul Mundt also suggested going for an asm-generic/hugetlb.h
approach. I'll send a new patch soon.
Thanks,
Gerald
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-14 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 18:48 [PATCH 0/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions Gerald Schaefer
2013-03-12 18:48 ` [PATCH 1/1] " Gerald Schaefer
2013-03-12 19:00 ` Chris Metcalf
2013-03-12 19:48 ` Gerald Schaefer
2013-03-14 13:14 ` Michal Hocko
2013-03-14 13:27 ` Hillf Danton
2013-03-14 14:11 ` Gerald Schaefer [this message]
2013-03-14 15:01 ` Michal Hocko
2013-03-12 19:00 ` [PATCH 0/1] " Paul Mundt
2013-03-12 19:28 ` Gerald Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314151109.5b6927ce@thinkpad \
--to=gerald.schaefer@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=dhillf@gmail.com \
--cc=fenghua.yu@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).