From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx169.postini.com [74.125.245.169]) by kanga.kvack.org (Postfix) with SMTP id 9B99F6B0036 for ; Fri, 15 Mar 2013 09:22:20 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-10-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv2, RFC 09/30] thp, mm: rewrite delete_from_page_cache() to support huge pages Content-Transfer-Encoding: 7bit Message-Id: <20130315132359.19AB9E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 15:23:59 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > wrote: > > + if (PageTransHuge(page)) { > > + int i; > > + > > + for (i = 0; i < HPAGE_CACHE_NR; i++) > > + radix_tree_delete(&mapping->page_tree, page->index + i); > > Move the below page_cache_release for tail page here, please. Okay. Thanks. > > + nr = HPAGE_CACHE_NR; > [...] > > + if (PageTransHuge(page)) > > + for (i = 1; i < HPAGE_CACHE_NR; i++) > > + page_cache_release(page + i); > > page_cache_release(page); -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org