From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id 429B26B0037 for ; Fri, 15 Mar 2013 09:48:47 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-9-git-send-email-kirill.shutemov@linux.intel.com> <20130315132333.B8205E0085@blue.fi.intel.com> Subject: Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache_locked() to support huge pages Content-Transfer-Encoding: 7bit Message-Id: <20130315135026.32B58E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 15:50:26 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Hillf Danton wrote: > On Fri, Mar 15, 2013 at 9:23 PM, Kirill A. Shutemov > wrote: > > Hillf Danton wrote: > >> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > >> wrote: > >> > + page_cache_get(page); > >> > + spin_lock_irq(&mapping->tree_lock); > >> > + page->mapping = mapping; > >> > + page->index = offset; > >> > + error = radix_tree_insert(&mapping->page_tree, offset, page); > >> > + if (unlikely(error)) > >> > + goto err; > >> > + if (PageTransHuge(page)) { > >> > + int i; > >> > + for (i = 1; i < HPAGE_CACHE_NR; i++) { > >> struct page *tail = page + i; to easy reader > >> > >> > + page_cache_get(page + i); > >> s/page_cache_get/get_page_foll/ ? > > > > Why? > > > see follow_trans_huge_pmd() please. Sorry, I fail to see how follow_trans_huge_pmd() is relevant here. Could you elaborate? -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org