From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx155.postini.com [74.125.245.155]) by kanga.kvack.org (Postfix) with SMTP id B463F6B0037 for ; Fri, 15 Mar 2013 13:05:32 -0400 (EDT) Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 Mar 2013 17:03:25 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9B47A1B08061 for ; Fri, 15 Mar 2013 17:05:28 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2FH5Jfr4194536 for ; Fri, 15 Mar 2013 17:05:19 GMT Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2FH5RqV016595 for ; Fri, 15 Mar 2013 11:05:28 -0600 Date: Fri, 15 Mar 2013 18:05:21 +0100 From: Gerald Schaefer Subject: Re: [PATCH v2] mm/hugetlb: add more arch-defined huge_pte functions Message-ID: <20130315180521.618460c5@vbox-ubuntu> In-Reply-To: <20130315160241.GD28311@dhcp22.suse.cz> References: <1363283463-50880-1-git-send-email-gerald.schaefer@de.ibm.com> <20130315160241.GD28311@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Mel Gorman , Hugh Dickins , Hillf Danton , Tony Luck , Fenghua Yu , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Paul Mundt , "David S. Miller" , Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Martin Schwidefsky , Heiko Carstens On Fri, 15 Mar 2013 17:02:41 +0100 Michal Hocko wrote: > On Thu 14-03-13 18:51:03, Gerald Schaefer wrote: > > Commit abf09bed3c "s390/mm: implement software dirty bits" > > introduced another difference in the pte layout vs. the pmd layout > > on s390, thoroughly breaking the s390 support for hugetlbfs. This > > requires replacing some more pte_xxx functions in mm/hugetlbfs.c > > with a huge_pte_xxx version. > > > > This patch introduces those huge_pte_xxx functions and their > > generic implementation in asm-generic/hugetlb.h, which will now be > > included on all architectures supporting hugetlbfs apart from s390. > > This change will be a no-op for those architectures. > > > > Signed-off-by: Gerald Schaefer > > yes this looks much better. I cannot talk about s390 part because I am > not familiar with it but the rest looks good to me. > > Maybe one nit, though. pte_page and pte_same do not have their > huge_Foo counterparts. Yes, a few pte_xxx calls remain. I left those because they still work on s390 (and all other archs apparently). I am thinking about a more complete cleanup, maybe eliminating the ambiguous use of pte_t for hugetlb completely. Not sure if I can get to it before Martin introduces the next s390 pte changes :) Thanks, Gerald -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org