From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] handle zcache_[eph|pers]_zpages for zero-filled page
Date: Sun, 17 Mar 2013 08:05:32 +0800 [thread overview]
Message-ID: <20130317000532.GA8297@hacker.(null)> (raw)
In-Reply-To: <20130316131104.GE5987@konrad-lan.dumpdata.com>
On Sat, Mar 16, 2013 at 09:11:06AM -0400, Konrad Rzeszutek Wilk wrote:
>On Fri, Mar 15, 2013 at 10:34:18AM +0800, Wanpeng Li wrote:
>> Increment/decrement zcache_[eph|pers]_zpages for zero-filled pages,
>> the main point of the counters for zpages and pageframes is to be
>> able to calculate density == zpages/pageframes. A zero-filled page
>> becomes a zpage that "compresses" to zero bytes and, as a result,
>> requires zero pageframes for storage. So the zpages counter should
>> be increased but the pageframes counter should not.
>>
>> [Dan Magenheimer <dan.magenheimer@oracle.com>: patch description]
>> Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
>
>Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thanks for your review Konrad. :-)
>> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>> ---
>> drivers/staging/zcache/zcache-main.c | 7 ++++++-
>> 1 files changed, 6 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
>> index 6c35c7d..ef8c960 100644
>> --- a/drivers/staging/zcache/zcache-main.c
>> +++ b/drivers/staging/zcache/zcache-main.c
>> @@ -863,6 +863,8 @@ static int zcache_pampd_get_data_and_free(char *data, size_t *sizep, bool raw,
>> if (pampd == (void *)ZERO_FILLED) {
>> handle_zero_filled_page(data);
>> zero_filled = true;
>> + zsize = 0;
>> + zpages = 1;
>> if (!raw)
>> *sizep = PAGE_SIZE;
>> goto zero_fill;
>> @@ -917,8 +919,11 @@ static void zcache_pampd_free(void *pampd, struct tmem_pool *pool,
>>
>> BUG_ON(preemptible());
>>
>> - if (pampd == (void *)ZERO_FILLED)
>> + if (pampd == (void *)ZERO_FILLED) {
>> zero_filled = true;
>> + zsize = 0;
>> + zpages = 1;
>> + }
>>
>> if (pampd_is_remote(pampd) && !zero_filled) {
>>
>> --
>> 1.7.7.6
>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-17 0:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 2:34 [PATCH v3 0/5] zcache: Support zero-filled pages more efficiently Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 1/5] introduce zero filled pages handler Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 2/5] zero-filled pages awareness Wanpeng Li
2013-03-16 14:12 ` Bob Liu
2013-03-17 0:04 ` Wanpeng Li
2013-03-17 0:04 ` Wanpeng Li
2013-03-19 0:50 ` Greg Kroah-Hartman
2013-03-19 1:23 ` Wanpeng Li
2013-03-19 1:23 ` Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 3/5] handle zcache_[eph|pers]_zpages for zero-filled page Wanpeng Li
2013-03-16 13:11 ` Konrad Rzeszutek Wilk
2013-03-17 0:05 ` Wanpeng Li
2013-03-17 0:05 ` Wanpeng Li [this message]
2013-03-15 2:34 ` [PATCH v3 4/5] introduce zero-filled page stat count Wanpeng Li
2013-03-15 2:34 ` [PATCH v3 5/5] clean TODO list Wanpeng Li
2013-03-19 0:23 ` [PATCH v3 0/5] zcache: Support zero-filled pages more efficiently Greg Kroah-Hartman
2013-03-19 1:13 ` Wanpeng Li
2013-03-19 1:13 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130317000532.GA8297@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).