From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/8] staging: zcache: zero-filled pages awareness
Date: Wed, 20 Mar 2013 18:43:49 +0800 [thread overview]
Message-ID: <20130320104349.GA21402@hacker.(null)> (raw)
In-Reply-To: <51498FCE.60603@oracle.com>
On Wed, Mar 20, 2013 at 06:30:38PM +0800, Bob Liu wrote:
>
>> @@ -641,16 +691,22 @@ static void zcache_pampd_free(void *pampd, struct tmem_pool *pool,
>> {
>> struct page *page = NULL;
>> unsigned int zsize, zpages;
>> + bool zero_filled = false;
>>
>> BUG_ON(preemptible());
>> - if (pampd_is_remote(pampd)) {
>> +
>> + if (pampd == (void *)ZERO_FILLED)
>> + zero_filled = true;
>> +
>> + if (pampd_is_remote(pampd) && !zero_filled) {
>> BUG_ON(!ramster_enabled);
>> pampd = ramster_pampd_free(pampd, pool, oid, index, acct);
>> if (pampd == NULL)
>> return;
>> }
>> if (is_ephemeral(pool)) {
>> - page = zbud_free_and_delist((struct zbudref *)pampd,
>> + if (!zero_filled)
>> + page = zbud_free_and_delist((struct zbudref *)pampd,
>> true, &zsize, &zpages);
>
>This check should also apply for !is_ephemeral(pool).
Good catch, fixed.
>
>> if (page)
>> dec_zcache_eph_pageframes();
>> @@ -667,7 +723,7 @@ static void zcache_pampd_free(void *pampd, struct tmem_pool *pool,
>> }
>> if (!is_local_client(pool->client))
>> ramster_count_foreign_pages(is_ephemeral(pool), -1);
>> - if (page)
>> + if (page && !zero_filled)
>> zcache_free_page(page);
>> }
>>
>>
>
>--
>Regards,
>-Bob
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-20 10:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 9:25 [PATCH v4 0/8] staging: zcache: Support zero-filled pages more efficiently Wanpeng Li
2013-03-19 9:25 ` [PATCH v4 1/8] staging: zcache: introduce zero-filled pages handler Wanpeng Li
2013-03-23 19:31 ` Geert Uytterhoeven
2013-03-19 9:25 ` [PATCH v4 2/8] staging: zcache: zero-filled pages awareness Wanpeng Li
2013-03-20 10:30 ` Bob Liu
2013-03-20 10:43 ` Wanpeng Li [this message]
2013-03-20 10:43 ` Wanpeng Li
2013-03-19 9:25 ` [PATCH v4 3/8] staging: zcache: handle zcache_[eph|pers]_zpages for zero-filled page Wanpeng Li
2013-03-19 9:25 ` [PATCH v4 4/8] staging: zcache: fix pers_pageframes|_max aren't exported in debugfs Wanpeng Li
2013-03-19 9:25 ` [PATCH v4 5/8] staging: zcache: fix zcache writeback " Wanpeng Li
2013-03-19 9:25 ` [PATCH v4 6/8] staging: zcache: fix static variables defined in debug.h but used in mutiple C files Wanpeng Li
2013-03-19 9:25 ` [PATCH v4 7/8] staging: zcache: introduce zero-filled page stat count Wanpeng Li
2013-03-19 9:25 ` [PATCH v4 8/8] staging: zcache: clean TODO list Wanpeng Li
2013-03-19 23:34 ` [PATCH v4 0/8] staging: zcache: Support zero-filled pages more efficiently Ric Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130320104349.GA21402@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).