From: Michal Hocko <mhocko@suse.cz>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, hugetlb: include hugepages in meminfo
Date: Wed, 20 Mar 2013 20:21:44 +0100 [thread overview]
Message-ID: <20130320192144.GD970@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1303201157120.17761@chino.kir.corp.google.com>
On Wed 20-03-13 11:58:20, David Rientjes wrote:
> On Wed, 20 Mar 2013, Michal Hocko wrote:
>
> > > I didn't do this because it isn't already exported in /proc/meminfo and
> > > since we've made an effort to reduce the amount of information emitted by
> > > the oom killer at oom kill time to avoid spamming the kernel log, I only
> > > print the default hstate.
> >
> > I do not see how this would make the output too much excessive. If
> > you do not want to have too many lines in the output then the hstate
> > loop can be pushed inside the node loop and have only per-node number
> > of lines same as you are proposing except you would have a complete
> > information.
> > Besides that we are talking about handful of hstates.
> >
>
> Sigh. Because nobody is going to be mapping non-default hstates and then
> not know about them at oom time;
If you are under control of the machine then you are right. But I was
already handling issues where getting any piece of information was
challenging and having this kind of information in the log would save me
a lot of time.
> 1GB hugepages on x86 with pse must be reserved at boot and never
> freed, for example. I'll add them but it's just a waste of time.
If you feel it is the waste of _your_ time then I am OK to create a folow
up patch. I really do not see any reason to limit this output,
especially when it doesn't cost us much.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-20 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 0:18 [patch] mm, hugetlb: include hugepages in meminfo David Rientjes
2013-03-20 9:53 ` Michal Hocko
2013-03-20 18:46 ` David Rientjes
2013-03-20 18:56 ` Michal Hocko
2013-03-20 18:58 ` David Rientjes
2013-03-20 19:21 ` Michal Hocko [this message]
2013-03-20 19:07 ` [patch v2] " David Rientjes
2013-03-20 19:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320192144.GD970@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).