From: Shaohua Li <shli@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>,
Rafael Aquini <aquini@redhat.com>,
riel@redhat.com, minchan@kernel.org, kmpark@infradead.org,
linux-mm@kvack.org
Subject: Re: [patch 1/4 v3]swap: change block allocation algorithm for SSD
Date: Thu, 21 Mar 2013 10:02:47 +0800 [thread overview]
Message-ID: <20130321020247.GA27300@kernel.org> (raw)
In-Reply-To: <20130320135858.179ceef83b43ce434373d55b@linux-foundation.org>
On Wed, Mar 20, 2013 at 01:58:58PM -0700, Andrew Morton wrote:
> On Tue, 19 Mar 2013 13:50:57 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
>
> > I find it a bit confusing that we now have these two different clustering
> > strategies in scan_swap_map(), one for SSD and one for the rest; and it's
> > not immediately obvious what's used for what.
>
> Yes, having two separation allocation paths is bad and we should work
> to avoid it, please. Sooner rather than later (which sometimes never
> comes).
>
> We have a few theories about how the SSD code will worsen things for
> rotating disks. But have those theories been tested? Any performance
> results? If regressions *are* observed, what is the feasibility of
> fixing them up?
The problem is I don't know which workload is proper to measure the cluster
change impact for rotating disks. That would only happen when swap is
fragmented but not too much. I'd assume the impact isn't big, but who knows. If
you have something I can test, I'm happy to do.
Will address other issues soon.
Thanks,
Shaohua
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-21 2:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 2:17 [patch 1/4 v3]swap: change block allocation algorithm for SSD Shaohua Li
2013-02-21 8:13 ` Kyungmin Park
2013-02-21 9:35 ` Shaohua Li
2013-03-12 15:12 ` Rafael Aquini
2013-03-12 15:19 ` Rafael Aquini
2013-03-18 5:09 ` Shaohua Li
2013-03-18 5:16 ` Simon Jeons
2013-03-18 6:40 ` Shaohua Li
2013-03-18 6:49 ` Simon Jeons
2013-03-18 21:02 ` Rafael Aquini
2013-03-19 1:31 ` Shaohua Li
2013-03-19 20:50 ` Hugh Dickins
2013-03-20 20:58 ` Andrew Morton
2013-03-21 2:02 ` Shaohua Li [this message]
2013-03-20 20:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321020247.GA27300@kernel.org \
--to=shli@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=hughd@google.com \
--cc=kmpark@infradead.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).