From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx123.postini.com [74.125.245.123]) by kanga.kvack.org (Postfix) with SMTP id 810B86B0006 for ; Thu, 21 Mar 2013 14:15:36 -0400 (EDT) Date: Thu, 21 Mar 2013 18:15:32 +0000 From: Mel Gorman Subject: Re: [PATCH 06/10] mm: vmscan: Have kswapd writeback pages based on dirty pages encountered, not priority Message-ID: <20130321181532.GP1878@suse.de> References: <1363525456-10448-1-git-send-email-mgorman@suse.de> <1363525456-10448-7-git-send-email-mgorman@suse.de> <20130317151155.GC2026@suse.de> <514B4925.2010909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <514B4925.2010909@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Andi Kleen , Linux-MM , Jiri Slaby , Valdis Kletnieks , Zlatko Calusic , Johannes Weiner , dormando , Satoru Moriya , Michal Hocko , LKML On Thu, Mar 21, 2013 at 01:53:41PM -0400, Rik van Riel wrote: > On 03/17/2013 11:11 AM, Mel Gorman wrote: > >On Sun, Mar 17, 2013 at 07:42:39AM -0700, Andi Kleen wrote: > >>Mel Gorman writes: > >> > >>>@@ -495,6 +495,9 @@ typedef enum { > >>> ZONE_CONGESTED, /* zone has many dirty pages backed by > >>> * a congested BDI > >>> */ > >>>+ ZONE_DIRTY, /* reclaim scanning has recently found > >>>+ * many dirty file pages > >>>+ */ > >> > >>Needs a better name. ZONE_DIRTY_CONGESTED ? > >> > > > >That might be confusing. The underlying BDI is not necessarily > >congested. I accept your point though and will try thinking of a better > >name. > > ZONE_LOTS_DIRTY ? > I had changed it to ZONE_TAIL_LRU_DIRTY, /* reclaim scanning has recently found * many dirty file pages at the tail * of the LRU. */ Is that reasonable? -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org