From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx159.postini.com [74.125.245.159]) by kanga.kvack.org (Postfix) with SMTP id 58FF46B0002 for ; Tue, 26 Mar 2013 19:04:01 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.8bytes.org (Postfix) with SMTP id F1BC412AFA1 for ; Wed, 27 Mar 2013 00:03:59 +0100 (CET) Date: Wed, 27 Mar 2013 00:03:59 +0100 From: Joerg Roedel Subject: Re: [PATCH] staging: zsmalloc: Fix link error on ARM Message-ID: <20130326230359.GD30540@8bytes.org> References: <1364337232-3513-1-git-send-email-joro@8bytes.org> <20130326224536.GA29952@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130326224536.GA29952@kroah.com> Sender: owner-linux-mm@kvack.org List-ID: To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue, Mar 26, 2013 at 03:45:36PM -0700, Greg Kroah-Hartman wrote: > On Tue, Mar 26, 2013 at 11:33:52PM +0100, Joerg Roedel wrote: > > Testing the arm chromebook config against the upstream > > kernel produces a linker error for the zsmalloc module from > > staging. The symbol flush_tlb_kernel_range is not available > > there. Fix this by removing the reimplementation of > > unmap_kernel_range in the zsmalloc module and using the > > function directly. > > > > Signed-off-by: Joerg Roedel > > Why is this not an error for any other architecture? Why is arm > special? The version of the function __zs_unmap_object() which uses flush_tlb_kernel_range() in the zsmalloc driver is only compiled in when USE_PGTABLE_MAPPING is defined. And USE_PGTABLE_MAPPING is defined in the same file only when CONFIG_ARM is defined. So this happens only on ARM. Regards, Joerg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org