From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx126.postini.com [74.125.245.126]) by kanga.kvack.org (Postfix) with SMTP id 0745D6B0006 for ; Thu, 28 Mar 2013 10:30:39 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: <514CA05D.6030302@sr71.net> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-17-git-send-email-kirill.shutemov@linux.intel.com> <514CA05D.6030302@sr71.net> Subject: Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page() Content-Transfer-Encoding: 7bit Message-Id: <20130328143227.61B0CE0085@blue.fi.intel.com> Date: Thu, 28 Mar 2013 16:32:27 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Dave Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Dave wrote: > On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > > +static int split_anon_huge_page(struct page *page) > > { > > struct anon_vma *anon_vma; > > int ret = 1; > > > > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); > > - BUG_ON(!PageAnon(page)); > > Did you really mean to kill these BUG_ON()s? They still look relevant > to me. The zero page BUG_ON() is moved to new split_huge_page(). !PageAnon(page) we now can handle. Note: nobody should call split_anon_huge_page() directly, only split_huge_page(). -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org