From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
hughd@google.com, riel@redhat.com, khlebnikov@openvz.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hanjun Guo <guohanjun@huawei.com>,
Zhangdianfang <zhangdianfang@huawei.com>
Subject: Re: [PATCH] mm/vmscan: fix error return in kswapd_run()
Date: Tue, 2 Apr 2013 19:20:41 +0800 [thread overview]
Message-ID: <20130402112041.GA17704@hacker.(null)> (raw)
In-Reply-To: <515ABC79.5060900@huawei.com>
On Tue, Apr 02, 2013 at 07:09:45PM +0800, Xishi Qiu wrote:
>Fix the error return value in kswapd_run(). The bug was
>introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34
>"mm/vmscan: fix error number for failed kthread".
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
>---
> mm/vmscan.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/mm/vmscan.c b/mm/vmscan.c
>index 88c5fed..950636e 100644
>--- a/mm/vmscan.c
>+++ b/mm/vmscan.c
>@@ -3188,9 +3188,9 @@ int kswapd_run(int nid)
> if (IS_ERR(pgdat->kswapd)) {
> /* failure at boot is fatal */
> BUG_ON(system_state == SYSTEM_BOOTING);
>- pgdat->kswapd = NULL;
> pr_err("Failed to start kswapd on node %d\n", nid);
> ret = PTR_ERR(pgdat->kswapd);
>+ pgdat->kswapd = NULL;
> }
> return ret;
> }
>--
>1.7.6.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-02 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 11:09 [PATCH] mm/vmscan: fix error return in kswapd_run() Xishi Qiu
2013-04-02 11:20 ` Wanpeng Li
2013-04-02 11:20 ` Wanpeng Li [this message]
2013-04-02 14:57 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130402112041.GA17704@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=qiuxishi@huawei.com \
--cc=riel@redhat.com \
--cc=zhangdianfang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).